Problem/Motivation

Currently listed tours in help page have links generated to pages where tour is available. When you click on tour, you get redirected to page, but tour does not start. In this case user went to page, because of tour and it would be useful if tour automatically starts. I think it's expected behaviour.

Proposed resolution

Append "tour=1" parameter to generated page link and tour will be displayed automatically.

Remaining tasks

  1. Add defined functionality in tour module. Related class should be: modules/tour/src/Plugin/HelpSection/TourHelpSection.php
CommentFileSizeAuthor
#23 2844897-23.patch4.48 KByogeshmpawar
#23 interdiff-2844897-19-23.txt1.92 KByogeshmpawar
#19 tour-help-link-starts-tour.gif260.86 KBthejimbirch
#19 tour-help-links-2844897-19.patch4.46 KBthejimbirch
#7 2844897_7_ONLY_TEST.patch3.28 KBmtodor
#7 2844897_7.patch4 KBmtodor
#7 2844897_7_ONLY_TEST.patch3.28 KBmtodor
#2 2844897_2.patch732 bytesmtodor

Comments

mtodor created an issue. See original summary.

mtodor’s picture

mtodor commented
Status: Active » Needs review
StatusFileSize
new 2844897_2.patch732 bytes

Here is proposed solution.

dawehner’s picture

dawehner
Primary language German
commented

That's a really nice change! Do you think we can provide test coverage for that?

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

realityloop’s picture

realityloop commented
Status: Needs review » Reviewed & tested by the community

+1

realityloop’s picture

realityloop commented
Status: Reviewed & tested by the community » Needs work

Missed dawehner's comment about tests

mtodor’s picture

mtodor commented
Status: Needs work » Needs review
StatusFileSize
new 2844897_7_ONLY_TEST.patch3.28 KB
new 2844897_7.patch4 KB
new 2844897_7_ONLY_TEST.patch3.28 KB

Here are tests for this functionality. There is also patch only with tests and that's at same time a interdiff.
And additionally we are rolling this out with 8.4.x.

The last submitted patch, 7: 2844897_7_ONLY_TEST.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: 2844897_7_ONLY_TEST.patch, failed testing.

mtodor’s picture

mtodor commented
Status: Needs work » Needs review

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

thejimbirch’s picture

thejimbirch commented
StatusFileSize
new tour-help-links-2844897-19.patch4.46 KB
new tour-help-link-starts-tour.gif260.86 KB

Very smart idea. Love it!

Patch attached that re-rolls the patch in #7 for Drupal 9.3

I applied the patch to a local site and recorded a screenshot of it working as expected.

Screen recording of tour opening automaticall when coming from the help page.

Fingers crossed the test passes.

Status: Needs review » Needs work

The last submitted patch, 19: tour-help-links-2844897-19.patch, failed testing. View results

thejimbirch’s picture

thejimbirch commented

I'm going to need help with that failing test. A bit beyond me.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: Unassigned » yogeshmpawar

working on test failures.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff-2844897-19-23.txt1.92 KB
new 2844897-23.patch4.48 KB

Added patch which will remove test failures & also added an interdiff for the same to review.

Status: Needs review » Needs work

The last submitted patch, 23: 2844897-23.patch, failed testing. View results

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Postponed
Issue tags: -Tour

This extension is being deprecated, see #3336033: [Meta] Tasks to deprecate Tour module. It will be removed from core and moved to a contrib project, #3376099: [11.x] [Meta] Tasks to remove Tour.

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

quietone’s picture

quietone commented
Project: Drupal core » Tour
Version: 11.x-dev » 1.0.x-dev
Component: tour.module » Code
Status: Postponed » Needs work
smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)

This still a desired feature? Having a hard time seeing the use case.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

Seems #3444773: Automatically open tour for the first time could be the new 2.0.x approach

Also in [#3214593 @ksenzee mentioned something 2 years ago. I've reached out to them about opening a ticket to add.