Problem/Motivation

Currently listed tours in help page have links generated to pages where tour is available. When you click on tour, you get redirected to page, but tour does not start. In this case user went to page, because of tour and it would be useful if tour automatically starts. I think it's expected behaviour.

Proposed resolution

Append "tour=1" parameter to generated page link and tour will be displayed automatically.

Remaining tasks

  1. Add defined functionality in tour module. Related class should be: modules/tour/src/Plugin/HelpSection/TourHelpSection.php
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

mtodor created an issue. See original summary.

mtodor’s picture

Status: Active » Needs review
FileSize
732 bytes

Here is proposed solution.

dawehner’s picture

That's a really nice change! Do you think we can provide test coverage for that?

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

realityloop’s picture

Status: Needs review » Reviewed & tested by the community

+1

realityloop’s picture

Status: Reviewed & tested by the community » Needs work

Missed dawehner's comment about tests

mtodor’s picture

Here are tests for this functionality. There is also patch only with tests and that's at same time a interdiff.
And additionally we are rolling this out with 8.4.x.

The last submitted patch, 7: 2844897_7_ONLY_TEST.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: 2844897_7_ONLY_TEST.patch, failed testing.

mtodor’s picture

Status: Needs work » Needs review

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.