Problem/Motivation

#2815831: Move Off-canvas related CSS from drupal.outside_in library to drupal.off_canvas recently went in and added two CSS files with incorrect indents.
While searching, found a few more

$ ag -l -G="*.css" "^\S.*{\n    "
core/modules/outside_in/css/offcanvas.css
core/modules/outside_in/css/offcanvas.motion.css
core/modules/system/css/system.admin.css
core/modules/views_ui/css/views_ui.admin.theme.css
core/tests/Drupal/Tests/Core/Asset/css_test_files/quotes.css
core/themes/bartik/color/preview.css
core/themes/stable/css/system/system.admin.css
core/themes/stable/css/views_ui/views_ui.admin.theme.css

I left core/tests/Drupal/Tests/Core/Asset/css_test_files/quotes.css alone since it is for testing whitespace and CSS aggregation.

Proposed resolution

Fix the remaining files.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#3 interdiff-2-3.txt886 bytesAnonymous (not verified)
#3 2844719-css-3.patch5.1 KBAnonymous (not verified)
#2 2844719-css-2.patch4.24 KBtim.plunkett

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new 2844719-css-2.patch4.24 KB

#1995272: [Meta] Refactor module CSS files inline with our CSS standards seems to be a more holistic approach, but I'll let someone else decide if this should stand on its own or not.

Anonymous’s picture

Anonymous (not verified) commented
Related issues: +#1995272: [Meta] Refactor module CSS files inline with our CSS standards
StatusFileSize
new 2844719-css-3.patch5.1 KB
new interdiff-2-3.txt886 bytes

Looks nice! And frankly, 4 spaces is not so necessary for the quotes.css. Rather, it is my mistake since the editor settings. Sorry for this.

gaurav.kapoor’s picture

gaurav.kapoor commented

https://www.drupal.org/files/issues/2844719-css-3.patch solves the issue.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Reviewed & tested by the community

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

cilefen’s picture

cilefen commented
Status: Reviewed & tested by the community » Postponed

Thank you everyone!

I tried to test this myself but found that because of #2799603: .csslintrc file format is invalid and results in "important is not a valid option", we cannot test this standard as described in step three of https://www.drupal.org/core/scope#coding-standards, so I am postponing it for now.

Also, there seems to be a meta #1190252: [573] Use csslint as a weapon to beat the crappy CSS out of Drupal core

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +DrupalCampNJ2017
Anonymous’s picture

Anonymous (not verified) commented

Can we closed this issue after #2878548: Fix CSS whitespace issues?

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Postponed » Closed (outdated)

We have automated linting checks now. I am closing this as outdated.