Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
#2815831: Move Off-canvas related CSS from drupal.outside_in library to drupal.off_canvas recently went in and added two CSS files with incorrect indents.
While searching, found a few more
$ ag -l -G="*.css" "^\S.*{\n "
core/modules/outside_in/css/offcanvas.css
core/modules/outside_in/css/offcanvas.motion.css
core/modules/system/css/system.admin.css
core/modules/views_ui/css/views_ui.admin.theme.css
core/tests/Drupal/Tests/Core/Asset/css_test_files/quotes.css
core/themes/bartik/color/preview.css
core/themes/stable/css/system/system.admin.css
core/themes/stable/css/views_ui/views_ui.admin.theme.css
I left core/tests/Drupal/Tests/Core/Asset/css_test_files/quotes.css alone since it is for testing whitespace and CSS aggregation.
Proposed resolution
Fix the remaining files.
Remaining tasks
N/A
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff-2-3.txt | 886 bytes | Anonymous (not verified) |
#3 | 2844719-css-3.patch | 5.1 KB | Anonymous (not verified) |
#2 | 2844719-css-2.patch | 4.24 KB | tim.plunkett |
Comments
Comment #2
tim.plunkett#1995272: [Meta] Refactor module CSS files inline with our CSS standards seems to be a more holistic approach, but I'll let someone else decide if this should stand on its own or not.
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedLooks nice! And frankly, 4 spaces is not so necessary for the quotes.css. Rather, it is my mistake since the editor settings. Sorry for this.
Comment #4
gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commentedhttps://www.drupal.org/files/issues/2844719-css-3.patch solves the issue.
Comment #5
gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commentedComment #7
cilefen CreditAttribution: cilefen commentedThank you everyone!
I tried to test this myself but found that because of #2799603: .csslintrc file format is invalid and results in "important is not a valid option", we cannot test this standard as described in step three of https://www.drupal.org/core/scope#coding-standards, so I am postponing it for now.
Also, there seems to be a meta #1190252: [573] Use csslint as a weapon to beat the crappy CSS out of Drupal core
Comment #8
xjmComment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedCan we closed this issue after #2878548: Fix CSS whitespace issues?
Comment #22
quietone CreditAttribution: quietone at PreviousNext commentedWe have automated linting checks now. I am closing this as outdated.