In lieu of being able to control the entity form using layouts, add an option at on the field to control whether it is displayed in the sidebar or the main column.

CommentFileSizeAuthor
#8 metatag-n2844696-8.patch3 KBdamienmckenna
#8 metatag-n2844696-8.interdiff.txt1.5 KBdamienmckenna
#6 metatag-n2844696-6.interdiff.txt466 bytesdamienmckenna
#6 metatag-n2844696-6.patch2.32 KBdamienmckenna
#2 metatag_2844696-2_sidebar_placement_optional.patch1.89 KBmichelle
#2 metatag_sidebar_3.png38.45 KBmichelle
#2 metatag_sidebar_2.png51.02 KBmichelle
#2 metatag_sidebar_1.png89.62 KBmichelle

Comments

DamienMcKenna created an issue. See original summary.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag_sidebar_1.png89.62 KB
new metatag_sidebar_2.png51.02 KB
new metatag_sidebar_3.png38.45 KB
new metatag_2844696-2_sidebar_placement_optional.patch1.89 KB

I added the option to the field widget:

It defaults to checked so it continues with standard behavior by default. If unchecked, the field goes with the other fields in the main area:

Status: Needs review » Needs work

The last submitted patch, 2: metatag_2844696-2_sidebar_placement_optional.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +Needs tests

Let's add some test coverage too.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

This is the error that's causing all of the test failures:

There was a problem creating field Meta tags: Schema errors for core.entity_form_display.node.article.default with the following errors: core.entity_form_display.node.article.default:content.field_meta_tags.settings.sidebar missing schem

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
Parent issue: » #3102475: Plan for Metatag 8.x-1.12
StatusFileSize
new metatag-n2844696-6.patch2.32 KB
new metatag-n2844696-6.interdiff.txt466 bytes

I wonder does this cover it?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Nice.

So now just need to add some test coverage.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: -Needs tests
StatusFileSize
new metatag-n2844696-8.interdiff.txt1.5 KB
new metatag-n2844696-8.patch3 KB

Moving the test coverage to #3114960: Add test coverage for the field widget sidebar option.

A minor polish on the changes.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thank you Michelle!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.