Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
Proposed resolution
Write EntityResourceTestBase subclass for the EntityViewMode entity.
Remaining tasks
References
1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.
Comment | File | Size | Author |
---|---|---|---|
#8 | 2843781-8.patch | 7.94 KB | Anonymous (not verified) |
#10 | 2843781-10.patch | 7.94 KB | Anonymous (not verified) |
#10 | interdiff-8-10.txt | 948 bytes | Anonymous (not verified) |
Comments
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #4
Wim LeersComment #6
Wim LeersThis is blocked on #2867266: Decouple access handlers for entity_view_mode and entity_form_mode from field_ui.module.
Comment #7
Wim LeersSee @vaplas' great work at #2843780-32: EntityResource: Provide comprehensive test coverage for EntityFormMode entity, hopefully he can do the same here!
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedA direct patch from #2843780-32 (coincidence up to the size of bytes!) the only difference is in the names
EntityFormMode/EntityViewMode
andentity_form_mode/entity_view_mode
.Comment #9
Wim LeersOnly one tiny thing was overlooked:
Nit: s/form/view/
After that's fixed, this is RTBC!
Comment #10
Anonymous (not verified) CreditAttribution: Anonymous commentedThank you, @Wim Leers! Eagle's sight!
Comment #11
Wim Leers👌
Comment #14
catchComment #15
Wim LeersUpdated #2824572-54: Write EntityResourceTestBase subclasses for every other entity type., #2868035-33: Test that all core content+config entity types have functional REST test coverage and #2910883-4: Move all entity type REST tests to the providing modules, each of their PP-count dropped by one!