CommentFileSizeAuthor
#8 2843781-8.patch7.94 KBAnonymous (not verified)
#10 2843781-10.patch7.94 KBAnonymous (not verified)
#10 interdiff-8-10.txt948 bytesAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Anonymous’s picture

Wim Leers’s picture

Issue tags: +php-novice, +API-First Initiative

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Wim Leers’s picture

Title: EntityResource: Provide comprehensive test coverage for EntityViewMode entity » [PP-1] EntityResource: Provide comprehensive test coverage for EntityViewMode entity
Status: Active » Postponed
Wim Leers’s picture

Title: [PP-1] EntityResource: Provide comprehensive test coverage for EntityViewMode entity » EntityResource: Provide comprehensive test coverage for EntityViewMode entity
Status: Postponed » Active
Issue tags: -Novice, -php-novice

See @vaplas' great work at #2843780-32: EntityResource: Provide comprehensive test coverage for EntityFormMode entity, hopefully he can do the same here!

Anonymous’s picture

Status: Active » Needs review
FileSize
7.94 KB

A direct patch from #2843780-32 (coincidence up to the size of bytes!) the only difference is in the names EntityFormMode/EntityViewMode and entity_form_mode/entity_view_mode.

Wim Leers’s picture

Status: Needs review » Needs work

Only one tiny thing was overlooked:

+++ b/core/modules/rest/tests/src/Functional/EntityResource/EntityViewMode/EntityViewModeResourceTestBase.php
@@ -0,0 +1,74 @@
+    $entity_form_mode = EntityViewMode::create([
...
+    $entity_form_mode->save();
+    return $entity_form_mode;

Nit: s/form/view/

After that's fixed, this is RTBC!

Anonymous’s picture

Status: Needs work » Needs review
FileSize
948 bytes
7.94 KB

Thank you, @Wim Leers! Eagle's sight!

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

👌

  • catch committed 43c0eca on 8.5.x
    Issue #2843781 by vaplas, Wim Leers: EntityResource: Provide...

  • catch committed c096f58 on 8.4.x
    Issue #2843781 by vaplas, Wim Leers: EntityResource: Provide...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.