Problem/Motivation

Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method

Proposed resolution

Write EntityResourceTestBase subclass for the NodeType entity.

Remaining tasks

References

1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.

CommentFileSizeAuthor
#6 interdiff-2843777-4-6.txt770 bytesshadcn
#6 entityresource_provide-2843777-6.patch8.04 KBshadcn
#4 entityresource_provide-2843777-4.patch8.18 KBshadcn

Comments

naveenvalecha created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

shadcn’s picture

shadcn commented
Assigned: Unassigned » shadcn

Working on this until #2853211: EntityResource::post() incorrectly assumes that every entity type has a canonical URL unblocks the other issues.

shadcn’s picture

shadcn commented
Status: Active » Needs review
StatusFileSize
new entityresource_provide-2843777-4.patch8.18 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented 
+++ b/core/modules/rest/tests/src/Functional/EntityResource/NodeType/NodeTypeResourceTestBase.php
@@ -0,0 +1,93 @@
+    if ($method === 'GET' || $method == 'PATCH' || $method == 'DELETE') {
+      return "The 'access content' permission is required.";
+    }

Interesting, why all of them but not POST?

shadcn’s picture

shadcn commented
Version: 8.3.x-dev » 8.4.x-dev
StatusFileSize
new entityresource_provide-2843777-6.patch8.04 KB
new interdiff-2843777-4-6.txt770 bytes

This was from \Drupal\Tests\rest\Functional\EntityResource\Node\NodeResourceTestBase::getExpectedUnauthorizedAccessMessage .

Fixed it for NodeTypeResourceTestBase .

Thanks @Wim Leers.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

I just tried to fix it for NodeResourceTestBase too, and that causes fails. So that code is necessary for NodeResourceTestBase. But #6 proves it's not necessary for NodeType.

So, this is good to go! Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5222fbf to 8.4.x and 3ed4688 to 8.3.x. Thanks!

  • alexpott committed 5222fbf on 8.4.x 
    Issue #2843777 by arshadcn, Wim Leers: EntityResource: Provide...

  • alexpott committed 3ed4688 on 8.3.x 
    Issue #2843777 by arshadcn, Wim Leers: EntityResource: Provide...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.