Problem/Motivation

Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method

Proposed resolution

Write EntityResourceTestBase subclass for the EntityTestBundle entity.

Remaining tasks

References

1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.

CommentFileSizeAuthor
#12 2843776-12.patch8.9 KBwim leers
#12 interdiff.txt2.05 KBwim leers
#8 2843776-8.patch8.48 KBwim leers
#8 interdiff.txt3.22 KBwim leers
#5 2843776-5.patch5.33 KBwim leers

Comments

naveenvalecha created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +php-novice, +API-First Initiative

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2843776-5.patch5.33 KB

And patch.

Anonymous’s picture

Anonymous (not verified) commented

Looks perfect! Hal tests?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » wim leers
Status: Needs review » Needs work

D'oh :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt3.22 KB
new 2843776-8.patch8.48 KB
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

🔥

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Hah :D

effulgentsia’s picture

effulgentsia commented
Status: Reviewed & tested by the community » Needs review

Patch looks great. Except I'm wondering:

+++ b/core/modules/hal/tests/src/Functional/EntityResource/EntityTestBundle/EntityTestBundleHalJsonAnonTest.php
@@ -0,0 +1,32 @@
+  /**
+   * {@inheritdoc}
+   */
+  protected static $format = 'hal_json';
+
+  /**
+   * {@inheritdoc}
+   */
+  protected static $mimeType = 'application/hal+json';

Why do the other HAL tests not also specify these?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new interdiff.txt2.05 KB
new 2843776-12.patch8.9 KB

Why do the other HAL tests not also specify these?

Because c/p error. Which means these two were testing json, not hal_json, which they inherited from \Drupal\Tests\rest\Functional\ResourceTestBase::$format, and that's why they were able to pass tests. Thankfully you noticed this!

👏 @effulgentsia 👏

effulgentsia’s picture

effulgentsia commented

Thanks! Adding review credit to @vaplas.

  • effulgentsia committed cc34cb8 on 8.5.x 
    Issue #2843776 by Wim Leers, vaplas: EntityResource: Provide...

  • effulgentsia committed 17ee3c5 on 8.4.x 
    Issue #2843776 by Wim Leers, vaplas: EntityResource: Provide...
effulgentsia’s picture

effulgentsia commented
Status: Reviewed & tested by the community » Fixed

Pushed to 8.5.x, and cherry picked to 8.4.x because this only adds tests, which is rc eligible.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.