Problem/Motivation

Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method

Proposed resolution

Write EntityResourceTestBase subclass for the FieldConfig entity.

Remaining tasks

References

1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.

CommentFileSizeAuthor
#3 entityresource_provide-2843766-3.patch8.82 KBshadcn

Comments

naveenvalecha created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

shadcn’s picture

shadcn commented
Version: 8.3.x-dev » 8.4.x-dev
Status: Active » Needs review
StatusFileSize
new entityresource_provide-2843766-3.patch8.82 KB

Ready for the bots.

Status: Needs review » Needs work

The last submitted patch, 3: entityresource_provide-2843766-3.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community
Related issues: +#2843756: EntityResource: Provide comprehensive test coverage for FieldStorageConfig entity

I have zero remarks :) Great job!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 757cfbb to 8.4.x and 5c5ae8a to 8.3.x. Thanks!

Backported to 8.3.x because its tests only.

  • alexpott committed 757cfbb on 8.4.x 
    Issue #2843766 by arshadcn: EntityResource: Provide comprehensive test...

  • alexpott committed 5c5ae8a on 8.3.x 
    Issue #2843766 by arshadcn: EntityResource: Provide comprehensive test...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.