Problem/Motivation

Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method

Proposed resolution

Write EntityResourceTestBase subclass for the Action entity.

Remaining tasks

References

1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.

CommentFileSizeAuthor
#7 interdiff.txt786 bytesAnonymous (not verified)
#7 rest_action-2843762-7.patch7.77 KBAnonymous (not verified)
#5 rest_action-2843762-5.patch7.76 KBAnonymous (not verified)

Comments

naveenvalecha created an issue. See original summary.

sumanthkumarc’s picture

sumanthkumarc commented
Assigned: Unassigned » sumanthkumarc

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sumanthkumarc’s picture

sumanthkumarc commented
Assigned: sumanthkumarc » Unassigned
Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new rest_action-2843762-5.patch7.76 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented 
  1. +++ b/core/modules/rest/tests/src/Functional/EntityResource/Action/ActionResourceTestBase.php
@@ -0,0 +1,89 @@
+      'label' => t('Add the anonymous role to the selected users'),

    Hah, this action doesn't really make sense, but that's okay for a test like this :) 

  2. +++ b/core/modules/rest/tests/src/Functional/EntityResource/Action/ActionResourceTestBase.php
@@ -0,0 +1,89 @@
+      'id' => $this->entity->id(),

    Can't we hardcode this ID?

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new rest_action-2843762-7.patch7.77 KB
new interdiff.txt786 bytes
  1. It was c/p from ActionTest::testDependencies(). Welcome any creative ideas ๏̮͡๏.
  2. Done, thanks!
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Thanks :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 478f2fb to 8.4.x and eadacb2 to 8.3.x. Thanks!

Add to 8.3.x since this is only test coverage.

  • alexpott committed 478f2fb on 8.4.x 
    Issue #2843762 by vaplas, Wim Leers: EntityResource: Provide...

  • alexpott committed eadacb2 on 8.3.x 
    Issue #2843762 by vaplas, Wim Leers: EntityResource: Provide...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.