Problem/Motivation

Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method

Proposed resolution

Write EntityResourceTestBase subclass for the SearchPage entity.

Remaining tasks

References

1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.

CommentFileSizeAuthor
#7 interdiff.txt1.62 KBAnonymous (not verified)
#7 rest_search_page-2843759-7.patch8.92 KBAnonymous (not verified)
#5 interdiff.txt1.8 KBAnonymous (not verified)
#5 rest_search_page-2843759-5.patch8.81 KBAnonymous (not verified)
#3 rest_search_page-2843759-3.patch8.78 KBAnonymous (not verified)

Comments

naveenvalecha created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new rest_search_page-2843759-3.patch8.78 KB

Status: Needs review » Needs work

The last submitted patch, 3: rest_search_page-2843759-3.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new rest_search_page-2843759-5.patch8.81 KB
new interdiff.txt1.8 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work 
  1. +++ b/core/modules/rest/tests/src/Functional/EntityResource/SearchPage/SearchPageResourceTestBase.php
@@ -0,0 +1,98 @@
+      '_core' => [
+        'default_config_hash' => $this->entity->get('_core')['default_config_hash'],
+      ],

    Why is this included?

    \Drupal\Tests\rest\Functional\EntityResource\Role\RoleResourceTestBase::getExpectedNormalizedEntity() and \Drupal\Tests\rest\Functional\EntityResource\Block\BlockResourceTestBase::getExpectedNormalizedEntity() don't include it, for example. 

  2. +++ b/core/modules/rest/tests/src/Functional/EntityResource/SearchPage/SearchPageResourceTestBase.php
@@ -0,0 +1,98 @@
+      'id' => $this->entity->id(),

    Let's hardcode this.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new rest_search_page-2843759-7.patch8.92 KB
new interdiff.txt1.62 KB

Fair remark. Looks like the reason for the appearance _core is the use of an existing configuration object (#2625258: LocaleConfigManager::updateConfigTranslations() deletes translations if a config object's name happens to match that of a shipped configuration object). But why I chose load() instead of create()? I do not know. Apparently the magical view of one line has overshadowed me :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks good now :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed df19756 to 8.4.x and aa5e072 to 8.3.x. Thanks!

  • alexpott committed df19756 on 8.4.x 
    Issue #2843759 by vaplas, Wim Leers: EntityResource: Provide...

  • alexpott committed aa5e072 on 8.3.x 
    Issue #2843759 by vaplas, Wim Leers: EntityResource: Provide...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.