EntityResource: Provide comprehensive test coverage for FilterFormat entity

+++ b/core/modules/filter/src/FilterFormatAccessControlHandler.php
@@ -21,7 +21,7 @@ protected function checkAccess(EntityInterface $filter_format, $operation, Accou
-    if ($operation == 'use') {
+    if ($operation == 'use' || $operation == 'view') {

I'm not sure this is desirable. using is very different from viewing. Viewing means you are allowed to see the filters in this text format… which may be sensitive. So I think that for $operation === 'view' you actually only want to grant access if the user has the administer filters permission.

Other than that, this is looking great!

I'll work in this. I sent to test with the version 8.4.x.

Looks perfect to me :)

+++ b/core/modules/filter/src/FilterFormatAccessControlHandler.php
@@ -20,6 +20,10 @@ class FilterFormatAccessControlHandler extends EntityAccessControlHandler {
+    if ($operation === 'view') {
+      return AccessResult::allowedIfHasPermission($account, 'administer filters');
+    }

Is there a generic issue discussing config entity view access? And it is worth considering adding generic behaviour to check the admin permission defined in a config entity' entity type plugin annotation?

Looking more deeply at the code... I think there might be a better fix. We can change:

    if (in_array($operation, ['disable', 'update'])) {
      return parent::checkAccess($filter_format, $operation, $account);
    }

to

    if (in_array($operation, ['disable', 'update', 'view'])) {
      return parent::checkAccess($filter_format, $operation, $account);
    }

Since in the parent class it does:

    if ($admin_permission = $this->entityType->getAdminPermission()) {
      return AccessResult::allowedIfHasPermission($account, $this->entityType->getAdminPermission());
    }

Less hard coding of permission names and more default behaviour...

+1!

Good catch, @alexpott :)

Committed and pushed 4826159 to 8.4.x and 8dfab09 to 8.3.x. Thanks!

I've committed this to 8.3.x because whilst there is a run-time change to FilterFormatAccessControlHandler is makes sense and could be considered a bugfix and has ample test coverage added.