Problem/Motivation

Drupal 8 is out for quite some time, and we need a D8 version of this module.

Proposed resolution

It's simple, just port it to D8.
There are already few attempts made to port this module, See : https://www.drupal.org/node/2387189

This version is a complete port to D8.

Remaining tasks

Testing the module. The updated and latest code of ported module is available in repo.

Please help us in PAR process: https://www.drupal.org/node/2849868

API changes

Search API has changed a lot in D8 from D7 please refer to: #2083471: Search module interacts with search plugins instead of finding implementations via hook_search_info

Git repo is maintained at : http://cgit.drupalcode.org/google_cse/log/?h=8.x-2.x

Comments

navneet0693 created an issue. See original summary.

navneet0693’s picture

navneet0693 commented

Git repo is now updated with some progress in porting.

navneet0693’s picture

navneet0693 commented

Finally it's working, we have some todo's left over to complete.

navneet0693’s picture

navneet0693 commented
Status: Active » Needs review

Minimal todo's left! I am marking this for review :) Please review.

navneet0693’s picture

navneet0693 commented
Assigned: navneet0693 » Unassigned
navneet0693’s picture

navneet0693 commented
navneet0693’s picture

navneet0693 commented
Related issues: +#2387189: [google_cse] Google Custom Search Engine
navneet0693’s picture

navneet0693 commented
Title: Port Google Custom Search Engine to Drupal 8 » [Meta] Port Google Custom Search Engine to Drupal 8
Issue summary: View changes
kreynen’s picture

kreynen commented

We've identified this as a project we need stable in D8 for the ~1,000 sites we run for the University of Colorado Boulder. We currently using a dedicated Google Search Appliance, but since that has been discontinued we are moving to CSE.

We'd be happy to help resolve the remaining issues with the D8 version @navneet0693 has been working on, add automated testing and work through the backlog of issues and feature requests in the queue. We are willing to own the project if that's required, but we can also just provide some support to get the D8 version to a 1.0 release.

I've reached out to @mfb. We don't want to step on anyone's toes or end up with too many cooks in the kitchen, but this project seems like it needs some immediate help coordinating resources.

If no one objects, please add @afinnarn and I as co-maintainers. We'll work with @navneet0693 to determine what role he wants to play and reach out to our development peers at other universities using this module to move the D8 branch forward.

mfb’s picture

mfb
they or he
commented

Thanks to everyone who's been working on the D8 branch, and thanks to @kreynen and @afinnarn for stepping up! I've added both as co-maintainers.

navneet0693’s picture

navneet0693 commented

@kreynen Thank you very much for your support, sorry I couldn't respond you in time as I am travelling. We can surely work out on the remaining issues. I would request you test the module and if you can edit this issue to add remaining tasks for solving the issues. @mfb I have contacted @alexmoreno and @malcomio, before starting project, for showing my interest in maintaining it too in future, and we were in conversation regarding the same. I also contacted @andypost for review as earlier attempt of port was done by him before working on it. For easier review, @alexmoreno asked me to create PR given here: https://github.com/alex-moreno/google-cse/pull/2/files, please feel free to review it.

navneet0693’s picture

navneet0693 commented

Can I get commit access as well? As I have spent more than a week and the module is in working condition now with the new version. I can push the code and others' can build on top of that. This would help reduce the duplication of the efforts.
The working version of the module can be found at : https://github.com/navneet0693/google_cse/releases

kreynen’s picture

kreynen commented

@navneet0693 Yes. Sorry if that wasn't clear. I tried to reach out using the Drupal.org contact form. Just tried Twitter and LinkedIn too.

navneet0693’s picture

navneet0693 commented

@kreynen Inboxed you :)

navneet0693’s picture

navneet0693 commented

@mfb @kreynen I have pushed the latest code to 8.x-2.x branch! http://cgit.drupalcode.org/google_cse/tree/?h=8.x-2.x

navneet0693’s picture

navneet0693 commented
Status: Needs review » Fixed
Related issues: +#2849854: Push code from git repo to 8.x-2.x branch of module

Code has been pushed, see: #2849854: Push code from git repo to 8.x-2.x branch of module. Please add issues in issue queues for reporting bugs.

navneet0693 credited Rick Hood.

navneet0693 credited alexmoreno.

navneet0693 credited andypost.

navneet0693’s picture

navneet0693 commented

Updating credits :)

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 7.x-2.4 » 8.x-2.x-dev
Status: Fixed » Needs work

Needs a beta release at least

andypost’s picture

andypost
he/him
Primary language Russian
commented

And there's still https://pareview.sh/node/987

navneet0693’s picture

navneet0693 commented

@andypost Yes, you are right, I was working on these: https://pareview.sh/node/979. For release, I have open an issue in PA to go through a PAR process: #2849868: [D8] Google Custom Search Engine.

navneet0693’s picture

navneet0693 commented
Issue summary: View changes
kreynen’s picture

kreynen commented
Status: Needs work » Fixed

I updated the release node so the dev snapshot is now downloadable from the project page.

Drupal.org's process for creating packaged releases is tedious and the community's flippant use of the alpha and beta tags have made those terms almost meaningless. Feeds has > 100K installs and is now in the 4th year of beta testing? While a project is in active development like this, anyone who wants to provide feedback and knows how to use git should be pulling from git.

The biggest reason for closing this and #2387189: [google_cse] Google Custom Search Engine so people stop adding new issues as comments. Any new issues should be made as part of a project review to #2849868: [D8] Google Custom Search Engine or opened as a new issue in this queue.

We be creating Plan issues early this week with the hope of getting to a rc release next week, but I don't see the point of alpha or beta release.

alexmoreno’s picture

alexmoreno commented

Sounds good to me

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.