As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#8 after_Patch_QuickTabs.png49.57 KBAanal.addweb
#7 remove_file_tag-2843001-6.patch41.04 KBgg24
#2 Remove@file_2843001_1.patch8.16 KBnehakhadke

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke commented
StatusFileSize
new Remove@file_2843001_1.patch8.16 KB
nehakhadke’s picture

nehakhadke commented
Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Unassigned » Munavijayalakshmi
Status: Needs review » Reviewed & tested by the community

@nehakhadke,Thanks for the patch it works well.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Munavijayalakshmi » Unassigned
gg24’s picture

gg24 commented
Assigned: Unassigned » gg24
Status: Reviewed & tested by the community » Needs work

In newer code base version 8.x-3.x-dev file structure has been changed. Some of the files do not exist anymore. Hence we need to re-roll this patch. Few deprecated functions are there as they are handled in separate issues. Handing indentation and removing extra used classes along with this only.

Thanks!

gg24’s picture

gg24 commented
Assigned: gg24 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new remove_file_tag-2843001-6.patch41.04 KB

Re-rolled patch. Handing indentation and removing extra used classes along with this only. Please review.

Thanks!

Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after_Patch_QuickTabs.png49.57 KB

@gg24, Thanks for the patch, it works well as I checked it manually by applying it in the module file. It works as expected. PFA as result.

systemick’s picture

systemick commented

gg24 - just applied the patch in #7. When trying to edit a quicktabs instance I got

Fatal error: Cannot declare class Drupal\quicktabs\Plugin\TabType\BlockContent because the name is already in use in /var/www/html/drupal-modules.localhost/modules/contrib/quicktabs/src/Plugin/TabType/BlockContent.php on line 19

If you re-roll the patch against the current dev branch I'll commit it.

shelane’s picture

shelane
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Part of larger effort to update for all coding standards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.