Problem/Motivation

To reproduce, install google translator as the only translator, make sure quick translation is enabled and then attempt to translate a job in the UI. It fails with a "The job has no provider assigned." exception, leaving the job in a broken, undefined state.

This is regression was caused with the refactoring for continuous translation and we have a single code base now for translating a whole job and translating some items, so we get the items and then the job again from them.

Proposed resolution

Save the job before completing quick-checkout.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Not sure how to write a test for this, maybe by loading and accessing the job translator in the test translator plugin.

Berdir’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests
Berdir’s picture

Status: Needs work » Needs review
FileSize
1.28 KB

Test translator doesn't use that method for normal translation. Lets see what happens if we do this...

Berdir’s picture

The last submitted patch, 5: save-fails-2842321-5-test-only.patch, failed testing.

  • Berdir committed 729744a on 8.x-1.x
    Issue #2842321 by Berdir: Quick checkout can fail if a translator loads...
Berdir’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.