To reproduce, install google translator as the only translator, make sure quick translation is enabled and then attempt to translate a job in the UI. It fails with a "The job has no provider assigned." exception, leaving the job in a broken, undefined state.
This is regression was caused with the refactoring for continuous translation and we have a single code base now for translating a whole job and translating some items, so we get the items and then the job again from them.
Save the job before completing quick-checkout.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | save-fails-2842321-5.patch | 2.51 KB | berdir |
| #5 | save-fails-2842321-5-test-only.patch | 1.84 KB | berdir |
| #4 | save-fails-2842321-4.patch | 1.28 KB | berdir |
| #2 | tmgmt-quick-checkout-save-2842321-1.patch | 686 bytes | berdir |
Comments
Comment #2
berdirNot sure how to write a test for this, maybe by loading and accessing the job translator in the test translator plugin.
Comment #3
berdirComment #4
berdirTest translator doesn't use that method for normal translation. Lets see what happens if we do this...
Comment #5
berdirThis should work as a test-only patch.
Comment #8
berdirCommitted.