Hi,

If the Drupal site was installed using composer drupal-scaffold, DRUPAL_ROOT is /web/.

simple_fb_connect_read_packages looks for a vendor directory in DRUPAL_ROOT, so in my case it's /web/vendor, which is wrong. Mine is /vendor/

I'm making a patch right now as I need a quick fix, I'll post it when it's done.

CommentFileSizeAuthor
#6 2841887-install-fails-if-drupal-root-is-web.patch863 bytessuperbiche
#2 2841887-install-fails-if-drupal-root-is-web.patch647 bytessuperbiche

Comments

superbiche created an issue. See original summary.

superbiche’s picture

superbiche commented
StatusFileSize
new 2841887-install-fails-if-drupal-root-is-web.patch647 bytes
masipila’s picture

masipila commented

Hi,

Thanks for reporting and for the patch!

Could you elaborate this a bit more so that I can be more confident committing this? In practise, what is the whole directory structure when you're using drupal-scaffold and what are the other differences?

Is it jist the .install runtime check that doesn't work or is there something else that isn't working (e.g. are the profile pics saved to correct directory etc)?

Markus

superbiche’s picture

superbiche commented

Hi,

You're welcome :)
Well, I didn't check if pictures were properly saved. I will do this now.

This is the root directory structure of a composer drupal-scaffold project:
.git/
.gitignore
.travis.yml
LICENSE
composer.json
composer.lock
config/
console/
drush/
lib/
log/
phpunit.xml.dist
scripts/
utils/
vendor/
web/

So even if I didn't test, I guess pictures are properly saved, as web/ is the web document root as well as DRUPAL_ROOT.

The patch simply checks if DRUPAL_ROOT . '/vendor' is a directory, and otherwise tries with dirname(DRUPAL_ROOT) . '/vendor'
Trivial but I needed a quick fix :)

I'll let you know about the pictures.

Michel

masipila’s picture

masipila commented

Hi,

got it, thanks for the explanation. Could you please add a line or two of inline comments explaining what is going on so that it will be easier for others to understand the code when looking at it later?

Cheers,
Markus

superbiche’s picture

superbiche commented
StatusFileSize
new 2841887-install-fails-if-drupal-root-is-web.patch863 bytes

There you are!

Ah, and thanks for the contrib. My client decided *today* the other module wasn't flexible enough, and the website is going live *tomorrow*. This module just saved my day :D

  • masipila committed b98302f on 8.x-3.x authored by superbiche 
    Issue #2841887 by superbiche: Install fails if DRUPAL_ROOT is /web/
masipila’s picture

masipila commented
Status: Active » Fixed

Committed to 8.x-3.x-dev.

Thanks once more for your contribution!

Cheers,
Markus

superbiche’s picture

superbiche commented

Great! You're welcome!

Oh and yes, the picture is correctly saved in my case :)

Best,
Michel

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.