Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The change in #1792738: Allow custom file view modes for WYSIWYG display moves the Media WYSIWYG View Mode functionality into the Media WYSIWYG module and refactors the way the module's configuration is stored.
This update doesn't retain any existing configuration and also doesn't show a message to the user to tell them they need to reconfigure it.
Comment | File | Size | Author |
---|---|---|---|
#4 | media-view_mode_config_migrate-2841742-4.patch | 1.68 KB | rooby |
| |||
#11 | media_old_settings_migration_2841742-11.patch | 1.61 KB | AbramOmovich |
|
Comments
Comment #2
rooby CreditAttribution: rooby commentedAround 20000 users have already done this update, however there are a lot that haven't and might be using this functionality so it still might be beneficial to address this.
Comment #3
joseph.olstadHi rooby , think you can figure out a patch between the two duplicate issues:
#2550431: View mode configuration should be stored along with the file type object, instead of variables
and
#1792738: Allow custom file view modes for WYSIWYG display
?
You had commented that 2550431 contained a patch that would have copied the settings over correctly, (however its patch didn't pass testing) could you maybe piece together the work that was done in that to make a new patch to fix this for those that haven't yet upgraded? I'd propose editing the same hook update , as those that have already upgraded probably manually restored their configuration and their old conf would have been deleted.
Comment #4
rooby CreditAttribution: rooby commentedI think the tests failed in that other issue because the tests needed changing for the new storage structure but hadn't been yet.
Here is a quick patch for the config migration. I have done one successful update from beta7 to latest dev with it.
Comment #6
joseph.olstadNice work rooby, I'll tag this for rc3
Comment #8
joseph.olstadThis change caused a regression:
Comment #9
sylus CreditAttribution: sylus commentedThink we can keep this as fixed and just focus on related issue. If inappropriate to do so please set back.
Comment #10
natew CreditAttribution: natew commentedComment #11
AbramOmovich CreditAttribution: AbramOmovich commentedHi, rooby, I've recently performed update from 7.x-2.0-alpha4 to 7.x-2.16 and I noticed that it has mistakes in migrating old variables in media_wysiwyg_update_7205.
Comment #12
AbramOmovich CreditAttribution: AbramOmovich commentedComment #13
joseph.olstadI recall this issue,
Thanks for the follow up. Push this improvement in asap.
There's still ~50000 installs that haven't yet upgraded from 1.x to 2.x
This patch should be committed to 2.x and cherry picked for 3.x and 4.x
Comment #14
joseph.olstadActually still reviewing it
Comment #15
joseph.olstadAbram, I am a bit nervous about making this change, can you describe the symptoms that led you to creating this patch?
Meanwhile I will try to have a look at the various tagged releases and see what possible variations there are in the variable names.
Thanks for your feedback.
Comment #19
joseph.olstadAbram, your patch looks good, thanks!
Comment #21
joseph.olstadthis recent change may have caused a regression for those upgrading from 7.x-1.x
still to be confirmed.