CookieResourceTestTrait test should send Content-Type request header

One thing I've noticed that has changed is that we're seeing

HTML output was generated
http://localhost/checkout/sites/simpletest/browser_output/Drupal_Tests_hal_Functional_EntityResource_Block_BlockHalJsonCookieTest-1-85940352.html

in the logs. This will be because the browser is run by root and can write anywhere so now it's doing browser output for functional php unit tests and just dumping the stuff in the root. oh boy.

On a local CI I can get the fail all the time. Adding some var_dumps() to:

  protected function initAuthentication() {
    // @todo Remove hardcoded use of the 'json' format, and use static::$format
    // + static::$mimeType instead in https://www.drupal.org/node/2820888.
    $user_login_url = Url::fromRoute('user.login.http')
      ->setRouteParameter('_format', 'json');

    $request_body = [
      'name' => $this->account->name->value,
      'pass' => $this->account->passRaw,
    ];

    $request_options[RequestOptions::BODY] = $this->serializer->encode($request_body, 'json');
    $request_options[RequestOptions::HEADERS]['Accept'] = 'application/json';
    var_dump($request_options);
    $response = $this->request('POST', $user_login_url, $request_options);

    var_dump($response);
    var_dump((string)$response->getBody());
    // Parse and store the session cookie.
    $this->sessionCookie = explode(';', $response->getHeader('Set-Cookie')[0], 2)[0];

    // Parse and store the CSRF token and logout token.
    $data = $this->serializer->decode((string)$response->getBody(), static::$format);
    $this->csrfToken = $data['csrf_token'];
    $this->logoutToken = $data['logout_token'];
  }

Output

Request:

array(2) {
      ["body"]=>
      string(39) "{"name":"tHiEojDX","pass":"yqS9hsT5EL"}"
      ["headers"]=>
      array(1) {
        ["Accept"]=>
        string(16) "application/json"
      }
    }

Response

    object(GuzzleHttp\Psr7\Response)#7951 (6) {
      ["reasonPhrase":"GuzzleHttp\Psr7\Response":private]=>
      string(2) "OK"
      ["statusCode":"GuzzleHttp\Psr7\Response":private]=>
      int(200)
      ["headers":"GuzzleHttp\Psr7\Response":private]=>
      array(4) {
        ["Date"]=>
        array(1) {
          [0]=>
          string(29) "Wed, 04 Jan 2017 14:04:27 GMT"
        }
        ["Server"]=>
        array(1) {
          [0]=>
          string(21) "Apache/2.4.7 (Ubuntu)"
        }
        ["Content-Length"]=>
        array(1) {
          [0]=>
          string(3) "493"
        }
        ["Content-Type"]=>
        array(1) {
          [0]=>
          string(29) "text/html; charset=iso-8859-1"
        }
      }
      ["headerNames":"GuzzleHttp\Psr7\Response":private]=>
      array(4) {
        ["date"]=>
        string(4) "Date"
        ["server"]=>
        string(6) "Server"
        ["content-length"]=>
        string(14) "Content-Length"
        ["content-type"]=>
        string(12) "Content-Type"
      }
      ["protocol":"GuzzleHttp\Psr7\Response":private]=>
      string(3) "1.1"
      ["stream":"GuzzleHttp\Psr7\Response":private]=>
      object(GuzzleHttp\Psr7\Stream)#16 (7) {
        ["stream":"GuzzleHttp\Psr7\Stream":private]=>
        resource(6657) of type (stream)
        ["size":"GuzzleHttp\Psr7\Stream":private]=>
        NULL
        ["seekable":"GuzzleHttp\Psr7\Stream":private]=>
        bool(true)
        ["readable":"GuzzleHttp\Psr7\Stream":private]=>
        bool(true)
        ["writable":"GuzzleHttp\Psr7\Stream":private]=>
        bool(true)
        ["uri":"GuzzleHttp\Psr7\Stream":private]=>
        string(10) "php://temp"
        ["customMetadata":"GuzzleHttp\Psr7\Stream":private]=>
        array(0) {
        }
      }
    }

Response body:

    string(493) "

    200 OK

OK
The server encountered an internal error or
misconfiguration and was unable to complete
your request.
Please contact the server administrator at
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.
More information about this error may be available
in the server error log.

"

So there are two apache error logs here is what is in them:

cat /var/log/apache2/error.log
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 172.17.0.5. Set the 'ServerName' directive globally to suppress this message
[Wed Jan 04 14:04:20.134760 2017] [mpm_prefork:notice] [pid 19] AH00163: Apache/2.4.7 (Ubuntu) PHP/7.0.15-dev configured -- resuming normal operations
[Wed Jan 04 14:04:20.134795 2017] [core:notice] [pid 19] AH00094: Command line: '/usr/sbin/apache2 -D FOREGROUND'

And

cat /var/log/apache2/test.apache.error.log
[Wed Jan 04 14:04:27.338512 2017] [:error] [pid 32] [client ::1:55204] Error while attempting to read POST data: 200

The second looks like the error but weird...

Looking at how Guzzle sends JSON from the client...

        if (isset($options['json'])) {
            $options['body'] = \GuzzleHttp\json_encode($options['json']);
            unset($options['json']);
            $options['_conditional']['Content-Type'] = 'application/json';
        }

We're missing $options['_conditional']['Content-Type'] = 'application/json';

So this fixes Drupal\Tests\hal\Functional\EntityResource\Block\BlockHalJsonCookieTest and the other tests using the \Drupal\Tests\rest\Functional\CookieResourceTestTrait::initAuthentication().

Now we just have a problem when we send unparseable bodies... these issues are all being caused by a recent addition to PHP7 see https://github.com/php/php-src/commit/9b65a10256e244a6d80027c943b163dd16... and https://github.com/php/php-src/pull/2180

So when I run Drupal\Tests\rest\Functional\EntityResource\User\UserJsonAnonTest I get the same issue being reported in the error log:

cat /var/log/apache2/test.apache.error.log
[Wed Jan 04 16:14:29.078809 2017] [:error] [pid 32] [client ::1:39654] Error while attempting to read POST data: 200

This time the test is doing this:

    $request_options[RequestOptions::HEADERS]['Content-Type'] = static::$mimeType;


    // DX: 400 when no request body.
    $response = $this->request('PATCH', $url, $request_options);
    $this->assertResourceErrorResponse(400, 'No entity content received.', $response);


    $request_options[RequestOptions::BODY] = $unparseable_request_body;


    // DX: 400 when unparseable request body.
    $response = $this->request('PATCH', $url, $request_options);

It's the last request here that is failing and that is because $unparseable_request_body; contains !{>}< which ain't JSON

@axot - yes it uses the PATCH method!

More info available on https://github.com/php/php-src/pull/2180#issuecomment-270602678

Well we should still commit #8 but maybe once PHP7 is rebuilt it won't be critical.

@Wim Leers well obviously something in the PHP7 change made the PHP SAPI stricter.

@axot I've built PHP7 including your PR and the tests that were failing now pass. That's not to say there might be some other effect but at least this issue won't happen again.

@axot if it was simple to run all test cases locally I would but it's not. We have far too many tests for that.