Ajax broken in payment_form submodule

Hi there !
I can confirm fix_ajax-1.patch works fine for me.
Thanks

I can confirm fix_ajax-1.patch works for me too. I hope it gets implemented in the main module soon!

Same here, can't wait!

the patch works for me too

Can confirm also that the patch worked for me too.

Confirming, that patch #1 is working for me.

Sorry for the slow response here.

This was using form state because the ID was dynamic, but this didn't work anymore like that.

However, now the ID is predictable, so I think we should simplify this and drop the form_state set/get, should not be required anymore. Just return the ID.

@Berdir: How could one 'predict' the ID? I personally do not have a clue. Shame that something so simplifiable is not happening. Would love to help out.

Also a very similar issue happens with the payment_reference_field submodule, see #3015819: Can not add line items to payment_reference_field. Maybe a higher level issue is needed here? Extract the code in both submodules to a more generic function?

Also, isn't this more of a UX issue?

What I mean is that get*Unique*Id() returns an ID that is different each time we call it. getId() does not, it will always return the same value for the same input.

So as I said, just remove the form_state stuff around it and simply return the value. If you want to help then update the patch :)

No, UX would be about a visual change to the user interface.

Hi @Berdir.
Take a look on this one.

It also resolves an issue with loosing line items, when user updates existing entity without touching previously created line items (I didn't find it reported anywhere).

I haven't completed extensive testing, but so far #23 works for me. Thanks for posting!

Reroll.

This was a tricky one, the web test actually tested deleting, but explicitly asserted that the item isn't *not* deleted. Fixed that, but required quite a few changes in the test to make it work.

Fixing the remaining unit test fail.

Committed.