Problem/Motivation

\Drupal\tmgmt\Form\TmgmtFormBase::__constructor
It doesn't call parent contstructur.

As a result, two members are uninitialised:
entityTypeBundleInfo and time

Proposed resolution

Fix... ;-)

CommentFileSizeAuthor
#8 Issue-2840331-8.patch1022 bytescburschka
#2 form-parent-2840331-2.patch2.29 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miro_dietiker created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
form-parent-2840331-2.patch2.29 KB

  • Berdir committed 691bbcc on 8.x-1.x 
    Issue #2840331 by Berdir: Missing parent call in TmgmtFormBase::...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Committed.

cburschka’s picture

cburschka
they
CreditAttribution: cburschka commented

This is targeting the 8.3.x branch, it seems - in the stable core version those two members don't exist yet...

  • Berdir committed b0bcac6 on 8.x-1.x 
    Revert "Issue #2840331 by Berdir: Missing parent call in TmgmtFormBase::...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Fixed » Active

Yep, reverted now.

cburschka’s picture

cburschka
they
CreditAttribution: cburschka commented
Status: Active » Needs review
FileSize
Issue-2840331-8.patch1022 bytes

For the 8.2.5, this is just a one-liner replacing the straight assignment with the parent call :)

(For now it doesn't change anything, but it makes the code future-proof for 8.3.x when it will let the parent use default values for the missing arguments.)

  • Berdir committed 1216c26 on 8.x-1.x authored by cburschka 
    Issue #2840331 by cburschka: Missing parent call in TmgmtFormBase::...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.