Hello,

I just tried your module on Drupal Core 8.2.4 and the settings value on page /admin/config/people/registration_role_with_approval are not saved.

Best,
Pascal

CommentFileSizeAuthor
#9 registration_role_with_approval-default-form-value-miss-2839851-9.patch2.46 KBemartos
#7 registration_role.png600.57 KBchuta
#6 registration_role_with_approval-default-form-value-miss-2839851-6.patch1.56 KBmylies

Comments

psiegel created an issue. See original summary.

Priyanka.addweb’s picture

Priyanka.addweb commented

It works fine and approval saved from my end.

Please flushed cache and reinstall module properly.

psiegel’s picture

psiegel commented

Hello,

I had tried this a few times without success. I have re-installed Drupal from scratch and tried again, same issue.

When I look and try to export (view) the configuration at /admin/config/development/configuration/single/export, the oly think I have is the brackets: { }

Is there anything I can look at to try to figure out what is happening?

Best,
Pascal

Ingulit’s picture

Ingulit commented
Priority: Normal » Critical

Confirming that none of this module's settings get saved when the save button is pressed. Presently unusable on Drupal 8.

mylies’s picture

mylies commented
Assigned: Unassigned » mylies
mylies’s picture

mylies commented
Assigned: mylies » Unassigned
Status: Active » Needs review
StatusFileSize
new registration_role_with_approval-default-form-value-miss-2839851-6.patch1.56 KB

changed saving configs on form submit and it works
hope its helps

chuta’s picture

chuta commented
StatusFileSize
new registration_role.png600.57 KB

@myLies....i Tried to apply this patch without success!
Here is the response i got;
startupbits@rs11 [~/public_html/modules/registration_role_with_approval]# patch < registration_role_with_approval-default-form-value-miss-2839851-6.patch
can't find file to patch at input line 5
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/Form/RegistrationRoleWithApprovalSettingsForm.php b/src/Form/RegistrationRoleWithApprovalSettingsForm.php
|index dffcb54..5a3a172 100644
|--- a/src/Form/RegistrationRoleWithApprovalSettingsForm.php
|+++ b/src/Form/RegistrationRoleWithApprovalSettingsForm.php
--------------------------
File to patch: registration_role_with_approval.module
patching file registration_role_with_approval.module
Hunk #1 FAILED at 96.
1 out of 1 hunk FAILED -- saving rejects to file registration_role_with_approval.module.rej
Can you assist?

Moneda’s picture

Moneda commented

I applied the patch #6 but is not working, the settings value are not saved.

emartos’s picture

emartos commented
StatusFileSize
new registration_role_with_approval-default-form-value-miss-2839851-9.patch2.46 KB
  • Changed the array keys.
  • Grouped the setters.

I have tested the patch and it applies correctly using Composer. With this patch, I am able to save the settings form and see the selected profiles on the registration form.

Kind regards,
Eduardo Martos.

matsbla’s picture

matsbla commented

I tested your patch Eduardo, looks like working good, thanks - I now get the role options on registration form.

However, it is missing a label, like "Select your roles".

I also tested with enabling the option "needs admin approval" for each role, but I was still able to register with those roles without any admin approval at all.

emartos’s picture

emartos commented

You are right. I focused on the saving problem, but there is also some work needed on code style. I think these details should go into different issues.

Regarding this:

I also tested with enabling the option "needs admin approval" for each role, but I was still able to register for those roles without any admin approval at all.

when I create new users selecting a role that needs approval, they remain blocked until the admin approves their accounts. The problem I've found is that the message these users receive is the same than roles without the approval required.

Kind regards,
Eduardo Martos.