Closed (won't fix)
Project:
Font Awesome Iconpicker
Version:
3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2016 at 17:56 UTC
Updated:
23 Jul 2024 at 21:40 UTC
Jump to comment: Most recent
Comments
Comment #2
d34dman commentedIf we are going to provide means to install and enable fontawesome then we can eventually remove dependency on that module too, as discussed in this issue - #2779197: Remove dependency on fontawesome
Comment #3
geerlingguy commentedYes, please :)
I've found that the fontawesome.module includes the library in a way that is broken with the latest version of Drupal Core (due to a Libraries API module quirk in 3.x-dev), so if we can make this module run without external dependencies, that would be ideal.
I'm going to post a patch soon...
Comment #4
truls1502Please let me know if you have worked with a patch to this issue?
Comment #5
geerlingguy commentedSorry, I'm not working the project for which I was using this module anymore, and I must've let the posting of this patch completely slip my mind. It seems like a case where someone who is motivated could add the dep by doing a
composer initto create a new composer.json with project typedrupal-project(I think), and add the dependency as mentioned earlier in this thread.Then, when you install the module via composer, it would automatically add the dependency. The module might need to have the path references for fontawesome be changed a little too.
Comment #6
truls1502I do not know if it makes sense to have the composer on 7.x version module? In 8.x, yes, but this issue is related to 7.x. :)
Comment #7
geerlingguy commentedAt the time this issue was created, there was no 8.x-1.x-dev branch; updating the issue metadata to match :)
Comment #8
truls1502Comment #9
d34dman commented