Markup differences, especially missing wrapper classes [#2839717]

This module is great and I'm making in a dependency for the DRD module. What I just discovered are 2 missing wrapper classes when a view is attached to an entity:

The class view-[view-name] should be added always
If the advanced settings of a view have another class being defined, that should also be added

Currently, they're both missing and instead the wrapper has this markup:

<div class="contextual-region js-view-dom-id-f2825972edb4a2034a0d9e5edb0eb048e34202d2a42f0d947f92f86809e65227">
  <div data-contextual-id="entity.view.edit_form:view=drd_domain:location=view&name=drd_domain&display_id=page_1&langcode=en" class="contextual">
...
  </div>
</div>

Those attributes are hard to be used in JavaScript and CSS. Any chance of getting the default classes added to the wrapper?

Comment	File	Size	Author
#7	eva-classy-wrapper-2839717-7.patch	3.92 KB	ahebrank
#3	eva-respect-custom-wrapper-class-2839717-3.patch	1.47 KB	ahebrank

Comments

Comment #1

28 December 2016 at 17:39

jurgenhaas created an issue. See original summary.

Comment #2

ahebrank commented 28 December 2016 at 18:33

These classes would be added in the template (here: https://github.com/ahebrank/eva/blob/8.x-1.x/templates/eva-display-entit... )-- it looks like having the views-* classes for a regular view build depends on the theme, because classy has them and stable does not (compare views-view.html.twig for those themes).

I don't really see any downside to adding them in to the template (i.e, more closely match the classy template). Feel free to put up a patch if you get to it before I do.

#2 is a bigger problem and I want to make sure I can replicate that.

Comment #3

ahebrank commented 28 December 2016 at 19:04

Status	File	Size
new	eva-respect-custom-wrapper-class-2839717-3.patch	1.47 KB

OK, this (copied over from core/modules/views) should take care of the second problem and provide template variables for the first.

Comment #4

ahebrank commented 28 December 2016 at 22:44

Assigned:	Unassigned	» ahebrank
Status:	Active	» Needs review

OK, find full diff and patch here:

https://github.com/ahebrank/eva/compare/issue-2839717?w=1
https://github.com/ahebrank/eva/compare/issue-2839717.patch

(I find a thread full of patches hard to follow; these links will stay current through the life of this issue, when the branch will be merged into dev).

RTBme -- let me know if these work or if anyone has issues with adding these classes by default.