As per the coding standard in Drupal 8

1. t() calls should be avoided in classes,
2. Expected 1 newline at end of file

CommentFileSizeAuthor
#2 coding-standard-2839352-02.patch10.02 KBharsha012

Comments

harsha012 created an issue. See original summary.

harsha012’s picture

harsha012 commented
StatusFileSize
new coding-standard-2839352-02.patch10.02 KB

Added patch

harsha012’s picture

harsha012 commented
Status: Active » Needs review
greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

This is a large patch and I'm having trouble getting all the small code standard fixes to apply. If someone has time, can they reroll this against the latest release?

~Greg

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Needs review » Needs work

  • Greg Boggs committed 5353e15 on 8.x-1.x authored by harsha012 
    Issue #2839352 by harsha012 and Greg Boggs: t() calls should be avoided...
greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

I went ahead and implemented this in the spirit of your patch. Let me know if I missed any.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.