When using Drupal.ajax commands or quickedit send request to server, server responses with error 500.
After investigation code, I found that AdvAgg throw new error when render js_assets array, which contain one element with index "-1" and empty array value.

CommentFileSizeAuthor
#8 advagg-check_empty_assets-2838940-6.patch666 bytesDenis Danielyan
#6 advagg-check_empty_assets-2838940-6.patch661 bytesDenis Danielyan
#2 advagg-check_empty_assets-2838940-2.patch512 bytesArchual

Comments

Archual created an issue. See original summary.

Archual’s picture

Archual commented
StatusFileSize
new advagg-check_empty_assets-2838940-2.patch512 bytes

I created patch, which check assets array for empty.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Active » Fixed

huh that's an odd and wrong thing. Safe work-around though, so applying, thanks. (and sorry for the delay)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Denis Danielyan’s picture

Denis Danielyan commented
StatusFileSize
new advagg-check_empty_assets-2838940-6.patch661 bytes

We experienced a similar issue. The array does not only contain one malformed entry but a malformed and a valid entry. This is why we changed the code slightly.

I have no idea where this comes from. The fix is only symptom-fighting but I have no in-depth knowledge of the module :-(.

Denis Danielyan’s picture

Denis Danielyan commented
Denis Danielyan’s picture

Denis Danielyan commented
StatusFileSize
new advagg-check_empty_assets-2838940-6.patch666 bytes
mikeytown2’s picture

mikeytown2 commented
Status: Closed (fixed) » Needs review

@Denis Danielyan
In the future open up a new issue

The last submitted patch, 2: advagg-check_empty_assets-2838940-2.patch, failed testing.

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed

#8 has been committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.