Views query substitutions not respected [#2838337]

I can't use hook_views_query_substitutions for the webform_nid option in a webform submission data field. It filters out my inserted replace pattern and the validation fails because it expects an autocomplete result.

Comment	File	Size	Author
#4	views_query-2838337-4.patch	7.07 KB	SpadXIII
#4	7.x-4.x: PHP 5.3 & MySQL 5.5, D7 18 pass PHP 5.6 & MySQL 5.5, D7 18 pass
#3	views_query-2838337-3.patch	7.07 KB	frank.schalkwijk
#3
#2	views_query-2838337-2.patch	7.07 KB	frank.schalkwijk
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

21 December 2016 at 14:20

frank.schalkwijk created an issue. See original summary.

Comment #2

frank.schalkwijk CreditAttribution: frank.schalkwijk commented 21 December 2016 at 14:47

File	Size
views_query-2838337-2.patch	7.07 KB

Comment #3

frank.schalkwijk CreditAttribution: frank.schalkwijk commented 21 December 2016 at 14:48

File	Size
views_query-2838337-3.patch	7.07 KB

#2 backported to 7.x-4.13

Comment #4

SpadXIII CreditAttribution: SpadXIII at ezCompany commented 27 November 2017 at 10:48

Status:

Active

» Needs review

File	Size
views_query-2838337-4.patch	7.07 KB
7.x-4.x: PHP 5.3 & MySQL 5.5, D7 18 pass PHP 5.6 & MySQL 5.5, D7 18 pass

I just updated the patch against latest 7.x

Comment #5

Liam Morland

English

Ontario, CA 🇨🇦

CreditAttribution: Liam Morland at University of Waterloo commented 27 November 2017 at 22:06

Thanks for the patch. I don't really understand the problem. Can you give an example of when this would appear? The patch really should include tests. The new functions should have more documentation, in particular, parameters and return values.