Only one site slogan character in site slogan when using PHP 7.1

I cannot reproduce this on PHP 7.1 so we need more information about this.

Are any contributed modules installed?

I'll try this.

I am bumping this to major because slogans are highly-visible. There appears to already be coverage in PageTitleTest.

@cmseasy Why did you downgrade this to normal (there could be reasons, but state them) and mark it postponed?

The earlier form state may have been loaded in your browser, no big deal.

Without the patch

Drupal test run
---------------

Tests to be run:
  - \Drupal\system\Tests\System\PageTitleTest

Test run started:
  Tuesday, January 3, 2017 - 10:57

Test summary
------------

\Drupal\system\Tests\System\PageTitleTest                     72 passes   1 fails  67 exceptions
- Found database prefix 'test31394419' for test ID 1.

Test run duration: 19 sec

With the patch applied

Drupal test run
---------------

Tests to be run:
  - \Drupal\system\Tests\System\PageTitleTest

Test run started:
  Tuesday, January 3, 2017 - 10:57

Test summary
------------

\Drupal\system\Tests\System\PageTitleTest                     73 passes            66 exceptions
- Found database prefix 'test62414564' for test ID 2.

Test run duration: 15 sec

So we've fixed the fail but we still have errors from the following code:

Exception Warning    Inline.php         175 Symfony\Component\Yaml\Inline::Symf
    A non-numeric value
    encounteredSymfony\Component\Yaml\Inline::Symfony\Component\Yaml\{closure}(0,
    'gc_probability')
    array_reduce(Array, Object, 0) (Line: 175)
    Symfony\Component\Yaml\Inline::dumpArray(Array, , ) (Line: 117)
    Symfony\Component\Yaml\Inline::dump(Array, , ) (Line: 59)
    Symfony\Component\Yaml\Dumper->dump(Array, 0, 0, , ) (Line: 70)
    Symfony\Component\Yaml\Dumper->dump(Array, 1, 4, , ) (Line: 70)
    Symfony\Component\Yaml\Dumper->dump(Array, 2, 0, , ) (Line: 98)
    Symfony\Component\Yaml\Yaml::dump(Array) (Line: 105)
    Drupal\simpletest\WebTestBase->prepareSettings() (Line: 422)
    Drupal\simpletest\WebTestBase->setUp() (Line: 30)
    Drupal\system\Tests\System\PageTitleTest->setUp() (Line: 947)
    Drupal\simpletest\TestBase->run(Array) (Line: 752)
    simpletest_script_run_one_test('3',
    '\Drupal\system\Tests\System\PageTitleTest') (Line: 66)

In order to fix the Symfony Yaml component issue we need to do #2840596: Update Symfony components to ~2.8.16

8.2.5 released and looks CI should be able to test 7.1 #2814933: PHP 7 test runs should be on released versions

The tiny patch in #8 is OK, but this is theoretically less disruptive (in case anyone was for whatever reason relying on the empty string in a later preprocess function, or something).

I like the fix in #18. I've applied locally and Drupal\system\Tests\System\PageTitleTest passes on 7.1. Let's get this done.

Committed/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!

after upgrading to php 7.1, I too am experiencing one letter in the Slogan.
Neither patch 8 or 18 solved this.

@paintingguy - there is no supported release with this patch yet - it'll be in 8.2.6 and 8.3.0

Thanks Alex, neither patch 8 or 18 worked. Was there a patch I could use until its added?

@paintingguy did you clear the cache? The patches here definitely work for core. Maybe you are using a custom or contrib theme that has the same bug. However there are more changes to support 7.1 - tbh honest it is worth waiting to 8.2.6 to move to 7.1.

Thanks Alex, I cleared my cache but it didn't help. Both patches broke the site so I and gave up.
I've reverted back to 7.0 and will wait as you suggest. Thanks for chiming in.

I'm using the stock Bartik, no mods to mention.

Broke the site? Can we get details on that please?

The moment I tried either of the patches my site went white (don't recall the error message). Could it be that I should have continued to try and rebuild Drupal?

When I saw that, I reverted back to the stock code and have now rolled back to php 7.0 and no longer have "Only one site slogan character in site slogan" .
Sorry, I'm not more helpful.

The patch in #18 applied to my own website (http://www.garfieldtech.com) running on 8.2 on PHP 7.1 works fine. Just make sure you do a full cache clear as Drupal 8 is very aggressive in its render caching. (And by default shows almost no debugging information for security reasons; you have to enable it.) It does sound like it could be a custom theme issue.

Tried patch #18 again. Did full cache clear. I get this. (The website encountered an unexpected error. Please try again later.)
This is a stock Bartik theme

paintingguys.ca

@paintingguy can you check the error log or use admin/config/development/logging to make errors visible on your site.

User warning: The following module is missing from the file system: visitors in drupal_get_filename() (line 236 of /home/painter/public_html/core/includes/bootstrap.inc) #0 /home/painter/public_html/core/includes/bootstrap.inc(548): _drupal_error_handler_real(512, 'The following m...', '/home/painter/p...', 236, Array) #1 [internal function]: _drupal_error_handler(512, 'The following m...', '/home/painter/p...', 236, Array) #2 /home/painter/public_html/core/includes/bootstrap.inc(236): trigger_error('The following m...', 512) #3 /home/painter/public_html/core/includes/bootstrap.inc(259): drupal_get_filename('module', 'visitors') #4 /home/painter/public_html/core/includes/module.inc(134): drupal_get_path('module', 'visitors') #5 /home/painter/public_html/core/includes/module.inc(93): module_load_include('install', 'visitors') #6 /home/painter/public_html/core/includes/install.inc(82): module_load_install('visitors') #7 /home/painter/public_html/core/modules/system/src/SystemManager.php(109): drupal_load_updates() #8 /home/painter/public_html/core/modules/system/src/SystemManager.php(96): Drupal\system\SystemManager->listRequirements() #9 /home/painter/public_html/core/modules/system/src/Controller/SystemController.php(114): Drupal\system\SystemManager->checkRequirements() #10 [internal function]: Drupal\system\Controller\SystemController->overview('system.admin_co...') #11 /home/painter/public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) #12 /home/painter/public_html/core/lib/Drupal/Core/Render/Renderer.php(574): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #13 /home/painter/public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #14 /home/painter/public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) #15 [internal function]: Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #16 /home/painter/public_html/vendor/symfony/http-kernel/HttpKernel.php(139): call_user_func_array(Object(Closure), Array) #17 /home/painter/public_html/vendor/symfony/http-kernel/HttpKernel.php(62): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #18 /home/painter/public_html/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #19 /home/painter/public_html/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #20 /home/painter/public_html/core/modules/page_cache/src/StackMiddleware/PageCache.php(99): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #21 /home/painter/public_html/core/modules/page_cache/src/StackMiddleware/PageCache.php(78): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #22 /home/painter/public_html/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #23 /home/painter/public_html/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #24 /home/painter/public_html/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(50): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #25 /home/painter/public_html/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #26 /home/painter/public_html/core/lib/Drupal/Core/DrupalKernel.php(652): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #27 /home/painter/public_html/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #28 {main}.

ParseError: syntax error, unexpected ']' in Drupal\Core\Extension\Extension->load() (line 843 of /home/painter/public_html/core/modules/system/system.module) #0 /home/painter/public_html/core/lib/Drupal/Core/Extension/ModuleHandler.php(127): Drupal\Core\Extension\Extension->load() #1 /home/painter/public_html/core/lib/Drupal/Core/Extension/ModuleHandler.php(140): Drupal\Core\Extension\ModuleHandler->load('system') #2 /home/painter/public_html/core/lib/Drupal/Core/DrupalKernel.php(544): Drupal\Core\Extension\ModuleHandler->loadAll() #3 /home/painter/public_html/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(45): Drupal\Core\DrupalKernel->preHandle(Object(Symfony\Component\HttpFoundation\Request)) #4 /home/painter/public_html/core/modules/page_cache/src/StackMiddleware/PageCache.php(99): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #5 /home/painter/public_html/core/modules/page_cache/src/StackMiddleware/PageCache.php(78): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #6 /home/painter/public_html/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #7 /home/painter/public_html/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #8 /home/painter/public_html/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(50): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #9 /home/painter/public_html/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #10 /home/painter/public_html/core/lib/Drupal/Core/DrupalKernel.php(652): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #11 /home/painter/public_html/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #12 {main}.

@paintingguy it sounds like the patch is incorrectly applied? Have a look at your system.module file around the lines in question (839 to 843)

I can't win with this patch, I feel like a bozo. As soon as I patch, I cannot access my site.

Here is my system.module

Could someone please replace what I need and I will copy the entire system.module. Thanks.

@paintingguy: if you want an entire system.module from Drupal 8.2.x with the patch applied, see:
http://cgit.drupalcode.org/drupal/blob/core/modules/system/system.module...

@pjcdawkins and others...

Thank you! Worked perfectly.