CommentFileSizeAuthor
#3 no_coding_standards_met-2837851-3.patch18.04 KBhongpong
#2 zurb-foundation-2837851-2.patch1.71 KBpifagor
codding.png228.04 KBpifagor

Comments

pifagor created an issue. See original summary.

pifagor’s picture

pifagor commented
Status: Active » Needs review
StatusFileSize
new zurb-foundation-2837851-2.patch1.71 KB

patch

hongpong’s picture

hongpong commented
StatusFileSize
new no_coding_standards_met-2837851-3.patch18.04 KB

Your patch had invisible characters for Windows line endings and a unicode directional character. I saved without BOM and changed all the templates to unix line endings in my editor.

hongpong’s picture

hongpong commented
Title: No coding standards met » No coding standards met, incorrect line endings

  • HongPong committed 34c4bb0 on 7.x-5.x 
    Issue #2837851 by pifagor, HongPong: No coding standards met, incorrect...
hongpong’s picture

hongpong commented
Version: 7.x-5.x-dev » 7.x-4.x-dev
Status: Needs review » Needs work

The same issue is on at least some of the 7.x-4.x files so I will change this issue to that branch. (foundation-1col.tpl.php has this issue at least) Thank you for sending in the code style fix!

hongpong’s picture

hongpong commented
Assigned: pifagor » hongpong