Currently automated testing is failing even with no code changes perhaps because of the changes in Feeds module.

The tests are now running with Feeds 7.x-2.0-beta3 whereas the previously passed test was running Feeds 7.x-2.0-beta2.

As a result submitted patches all automatically fail testing.

I'm attaching a patch with just a minimal change just to run it through the automated testing to prove my point. Not sure how to re-run the tests otherwise.

(Spawned from https://www.drupal.org/node/1461308#comment-11826737)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

victoriachan created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, nochange.patch, failed testing.

MegaChriz’s picture

Status: Needs work » Needs review
FileSize
2.04 KB

In #2648304: RSS 2.0: add support for item->source element a new mapping source was added for RSS feeds to support the optional <source> element. Because of this, the source item contained additional data and this resulted into the Feeds Tamper plugin 'Calculate hash' to produce a different result as before as that plugin generates a hash of the whole item. And if the data changes, so do the hashes.

The other test failure is caused by that the FeedsTamperEfqFinderTestCase adds the permission 'administer fields', which also happens to be added by Feeds itself since the beta3 version, causing the permission to be declared twice and thus causing issues. (To prevent this from happening in future versions, Feeds should filter out duplicate permissions before proceeding the tests.)

The attached patch should fix both test failures. For FeedsTamperEfqFinderTestCase by removing the duplicate permission 'administer fields' and for FeedsTamperUIWebTestCase by updating the expected hash values.

victoriachan’s picture

Status: Needs review » Reviewed & tested by the community

Great work, thanks! Can we get this committed please?

MegaChriz’s picture

I have sent a note to the maintainer.

  • twistor committed db26e1b on 7.x-1.x authored by MegaChriz
    Issue #2835936 by victoriachan, MegaChriz: Fix automated testing
    
twistor’s picture

Status: Reviewed & tested by the community » Fixed

@MegaChriz, you should have commit access now.

Thanks!

MegaChriz’s picture

Okay, great! I expect to not do much with Feeds Tamper, though. I already got my hands full on Feeds. But nevertheless handy for the next time that I break Feeds Tamper tests by a change in Feeds. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.