Problem/Motivation

There is no easy way to get to a specific translation from the source overview

Proposed resolution

the icon for a source/language combination should link to the existing translation if one exists.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 link_the_status_icon_on-2835755-9.patch3.76 KBVladimirMarko
#9 interdiff-2835755-6-9.txt1.14 KBVladimirMarko
#9 link_the_status_icon_on-2835755-9-test-only.patch2.83 KBVladimirMarko
#6 link_the_status_icon_on-2835755-6.patch3.73 KBVladimirMarko
#6 link_the_status_icon_on-2835755-6-test-only.patch2.79 KBVladimirMarko
#3 link_the_status_icon_on-2835755-3.patch958 bytesVladimirMarko

Comments

Berdir created an issue. See original summary.

VladimirMarko’s picture

VladimirMarko commented
Assigned: Unassigned » VladimirMarko
VladimirMarko’s picture

VladimirMarko commented
StatusFileSize
new link_the_status_icon_on-2835755-3.patch958 bytes
VladimirMarko’s picture

VladimirMarko commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: link_the_status_icon_on-2835755-3.patch, failed testing.

VladimirMarko’s picture

VladimirMarko commented
Status: Needs work » Needs review
StatusFileSize
new link_the_status_icon_on-2835755-6-test-only.patch2.79 KB
new link_the_status_icon_on-2835755-6.patch3.73 KB

I amended the tests to expect the new <a> tags in the table and added new assertions to test for the new links.

The last submitted patch, 6: link_the_status_icon_on-2835755-6-test-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: link_the_status_icon_on-2835755-6.patch, failed testing.

VladimirMarko’s picture

VladimirMarko commented
Status: Needs work » Needs review
StatusFileSize
new link_the_status_icon_on-2835755-9-test-only.patch2.83 KB
new interdiff-2835755-6-9.txt1.14 KB
new link_the_status_icon_on-2835755-9.patch3.76 KB

The new part of the test is now looking for substrings in the href attribute, instead of matching strings.

It works for me locally and should work on the testbot server this time, as well.

The last submitted patch, 9: link_the_status_icon_on-2835755-9-test-only.patch, failed testing.

  • Berdir committed 8c35a89 on 8.x-1.x authored by VladimirMarko 
    Issue #2835755 by VladimirMarko: Link the status icon on the source...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

That's quite a lot of hardcoded ID's but we already do that elsewhere in this test, so fine I think. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.