If I visit a panelizered node, and I have permission to change content, but not the layout, then the IPE does not show.

The problem is with the recent change from #2823912: Panelizer's permissions don't play well with IPE permissions the logic in that patch is just a little off.

CommentFileSizeAuthor
#9 panelizer-n2835582-9.patch5.7 KBdamienmckenna
#6 panelizer-n2835582-6.patch4.88 KBdamienmckenna
#2 panelizer-ipe-permissions-2835582-2.patch645 bytesdalin

Comments

dalin created an issue. See original summary.

dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented
Assigned: dalin » Unassigned
Status: Active » Needs review
StatusFileSize
new panelizer-ipe-permissions-2835582-2.patch645 bytes
dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented
Parent issue: #2823912: Panelizer's permissions don't play well with IPE permissions » #2787147: Plan for Panelizer 7.x-3.5 release
Related issues: +#2823912: Panelizer's permissions don't play well with IPE permissions
bneil’s picture

bneil commented
Status: Needs review » Reviewed & tested by the community

The patch in #2 works as expected.

Before the patch, if a user had "Use the Panels In-Place Editor" without "Change layouts with the Panels In-Place Editor", the IPE would not show. After the patch, it does show with the "Customize this page" button.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Lets add some tests for this.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new panelizer-n2835582-6.patch4.88 KB

Yeah, the permissions are way off, as highlighted by removing the "administer panelizer" permission on the tests.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: panelizer-n2835582-6.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new panelizer-n2835582-9.patch5.7 KB

The two patches together.

Status: Needs review » Needs work

The last submitted patch, 9: panelizer-n2835582-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The tests are failing because of CTools.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

  • DamienMcKenna committed eab5f4d on 7.x-3.x authored by dalin 
    Issue #2835582 by DamienMcKenna, dalin, bneil: IPE is only showing if...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.