When the using a custom payment rule that enables the stripe payment method, the module throws these errors:
The custom rule is set up correctly and everything is working fine, but the warnings seem to be triggered by the disabled default rule, which does not include any settings (and shouldn't need to). Adding settings to the disabled rule make the warning go away, but it seems like the module should check if any enabled rule is using stripe, not just the default.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-2835564-04-06-do-not-test.diff | 2.69 KB | lisastreeter |
| #6 | warning_messages-2835564-06.patch | 3.79 KB | lisastreeter |
Comments
Comment #2
torgospizzaThanks for the report! I believe this is a side effect of #2502109: Prevent Add/Update Card Functionality From User Tab with Stripe Checkout.
I'm trying to think of another way to handle this that doesn't involve invoking Rules. I suppose we could probably alter the update form callback, etc., to throw an error if we're not configured, but honestly I'm pretty sure this has been fixed in 3.x with some of the more recent changes (specifically #2703577: Add Card on File management for Stripe Checkout integration method).
If this is the case, and no one has a problem with allowing CoF updates on the User Tab when using Checkout integration (I can't think of any objections) then I will write a patch that just removes some of the rules invocations and conditions.
Comment #3
rszrama commentedI noticed this myself, as it will cause a problem when we're using Stripe Connect to fetch API credentials rather than having the merchant input them directly. Whether you're using the default rule or not, you won't end up with values in those fields.
I don't really think we need a warning on every admin page request - a warning on installation and perhaps a status report notice that doesn't generate messages should be sufficient. Lemme know if I'm misunderstanding the intent behind the messages, though.
Comment #4
lisastreeter commentedSome of the warning messages went away as a result of the patch for Issue #2957470 : Merge default values into the $settings array in commerce_stripe_settings_form()
This patch just removes a few more. It modifies the commerce_stripe.module file and is dependent on the patch submitted for Issue #2957469: Validate all functionality against latest Stripe PHP library:
latest_api_library-2957469-04.patch
Comment #5
rszrama commentedWill need a reroll after #2957470-8: Merge default values into the $settings array in commerce_stripe_settings_form().
Comment #6
lisastreeter commentedRerolled the patch and made additional changes to fix error messages that were still appearing on the payment method edit form. (Those errors were fixed in the original patch for #2957470-8: Merge default values into the $settings array in commerce_stripe_settings_form(), but reducing the scope of that patch left them unfixed.)
Comment #7
rszrama commentedReviewed and committed.