I am working with webform, version 4.14, and just noticed that the page where I see my own submissions, has "lost" it's breadcrumb. Page is node/%webform_menu/submissions
webform_2

and is rendered by webform_results_submissions in webform.report.inc.

It's true that breadcrumb does work for submissions on node/%webform_menu/webform-results

webform_1

Believe it's related to #2327993: Breadcrumb and active menu trail incorrect on submission confirmation page, where that patch as removed the rendering of breadcrumb on first page referenced above.

thank you

Comments

cornelyus created an issue. See original summary.

cornelyus’s picture

Issue summary: View changes
cornelyus’s picture

Issue summary: View changes
liam morland’s picture

Issue summary: View changes

Did it work before the changes in #2327993: Breadcrumb and active menu trail incorrect on submission confirmation page? Are you able to identify the commit where it broke?

cornelyus’s picture

I am not sure how it worked, I just saw it doesn't show up now.. searched here on the issues, saw that issue about it.. and in this commit http://cgit.drupalcode.org/webform/commit/?id=554a6ef

diff --git a/includes/webform.report.inc b/includes/webform.report.inc
index aae4b01..8dfd6a3 100644
--- a/includes/webform.report.inc
+++ b/includes/webform.report.inc
@@ -28,7 +28,6 @@ function webform_results_submissions($node, $user_filter, $pager_count) {
         drupal_set_title(t('Your submissions'));
         webform_disable_page_cache();
       }
-      webform_set_breadcrumb($node);
       return $view->preview('default', array($node->nid, $user->uid));
     }
     else {
   }
liam morland’s picture

Does reversing that change fix it?

cornelyus’s picture

For me, it did.

liam morland’s picture

Can you make a patch with your proposed change?

cornelyus’s picture

Patch uploaded!

avpaderno’s picture

Title: No breadcrumb for "own submissions" » No breadcrumbs for "own submissions"
Status: Active » Needs review
Issue tags: -breadcrumb +breadcrumbs
liam morland’s picture

Status: Needs review » Needs work

Patch needs to pass testing.

avpaderno’s picture

The patch doesn't apply because it's corrupted at line 14.

liam morland’s picture

Status: Needs work » Closed (outdated)

Drupal 7 is no longer supported. If this applies to a supported version, please re-open.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.