This task is for a new student in MD Systems, don't do it if it was not assigned to you.

Problem/Motivation

Currently, Drupal\tmgmt\TranslatorPluginBase class inherits PluginBase based in Drupal's Component namespace. It misses translation wrapper and serialization support which are needed for TMGMT translators. In order to avoid code duplication, we should switch to Drupal's Core PluginBase class.

Proposed resolution

Update Drupal\tmgmt\TranslatorPluginBase and make Drupal\Core\Plugin\PluginBase its base class.
Also, make sure (TranslatorPluginBase) implementations are updated, so StringTranslationTrait and DependencySerializationTrait are removed.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 plugin-base-core-2834807-3.patch392 bytesberdir

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan commented
Issue summary: View changes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new plugin-base-core-2834807-3.patch392 bytes

Taking this over as it kind of needs to be synced across multiple projects.

The only one to use this right now is Acclaro, Problem is that changing that will fail with the current RC.

  • Berdir committed 952a25a on 8.x-1.x 
    Issue #2834807 by Berdir: Make TranslatorPluginBase inherit Drupal's...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committed.

  • Berdir committed 875aeb5 on 8.x-1.x 
    Revert "Issue #2834807 by Berdir: Make TranslatorPluginBase inherit...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Fixed » Active

Reverted.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

See #2846252: Dependency on a non-existent datetime.time service

  • Berdir committed 89beaa7 on 8.x-1.x 
    Revert "Revert "Issue #2834807 by Berdir: Make TranslatorPluginBase...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Fixed

Wrong commit reverted :-/

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.