DropzoneJsElementTest checks for the presence of its script by looking for a script element containing modules/dropzonejs/js/dropzone.integration.js.

There is no requirement to install modules at a particular location - in particular, many sites use paths like modules/contrib/* and modules/custom/* to distinguish third-party modules from custom modules. Since the path modules/contrib/dropzonejs/js/dropzone.integration.js will not match the check, the unit test will fail.

CommentFileSizeAuthor
#3 hardcoded_module_path-2834781-3.patch821 byteschr.fritsch
#2 0001-Issue-2834781-Remove-hardcoded-modules-dropzonejs-pa.patch1.17 KBcburschka

Comments

cburschka created an issue. See original summary.

cburschka’s picture

cburschka
they
commented
Status: Active » Needs review
StatusFileSize
new 0001-Issue-2834781-Remove-hardcoded-modules-dropzonejs-pa.patch1.17 KB

This patch removes the "modules" to accept any path that contains "/dropzonejs/js/dropzone.integration.js"/

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
StatusFileSize
new hardcoded_module_path-2834781-3.patch821 bytes

This needs a reroll

  • chr.fritsch committed e5af7b7 on 8.x-1.x 
    Issue #2834781 by cburschka, chr.fritsch: Hardcoded module path in JS...
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Fixed

Very nice. Thank you. This should also fix our Travis integration

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.