The current check in commerce_checkout_password_form_alter causes the password fields not to show up when the NoCart module is used because it uses the name commerce_checkout_form_checkout_direct instead of commerce_checkout_form_checkout.

CommentFileSizeAuthor
#2 add-nocart-checkout-compatability-1.patch655 byteskingdutch

Comments

Kingdutch created an issue. See original summary.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new add-nocart-checkout-compatability-1.patch655 bytes

The attached patch checks if the first part of the $form_id equals commerce_checkout_form_checkout so it works with both forms.

cravecode’s picture

cravecode commented

@Kingdutch, the patch looks good. I'll merge the patch as soon as I'm back to my dev machine.

Thank you for your contribution!

cravecode’s picture

cravecode commented
Status: Needs review » Fixed

@Kingdutch, I ended up doing the same thing for the issue: Allow moving Account Password pane to custom checkout page. I wish I would have remembered your contribution while i was working on that. You solution is pretty much exactly what I did there. I'm sorry I didn't attribute you in the comment :(

Grab the latest the dev branch for the fix!

cravecode’s picture

cravecode commented
Status: Fixed » Closed (fixed)