Add a primary key to 'flag_types' for cluster replication support

+++ b/flag.install
@@ -135,6 +135,12 @@ function flag_schema() {
+        'description' => 'The unique identifier for this flag type.',

That description isn't correct. Each row here isn't a flag type, it's just part of the flag bundle setting.

Just call this something like 'Serial primary key'. It's nothing to do with the flag at all and we don't want people to think it might be.

BTW, there's another issue somewhere to fold this table into serialized data.

New patch as the hook_update was jumping one number

To keep consistency with the other tables, I used fid as primary key in this new patch

The patch gives the following error if trying to add multiple bundles on the same flag (no difference if flag is new like the one that gives me this error or updated):

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '11' for key 'PRIMARY': INSERT INTO {flag_types} (fid, type) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1); Array.... in flag_flag->insert()

this line in the patch:

db_add_primary_key($db_table, array('fid'));

should be:

db_add_primary_key($db_table, array('fid', 'type'));

You are perfectly right, i have the same issue and tested your patch successfully
Thank you :)
I am marking as RTBC

Thank you too, Delphine!

Closed as outdated because Drupal 7 is EOL