Problem/Motivation

Wrong name for "JavaScript".

Proposed resolution

Fix the naming.

CommentFileSizeAuthor
#2 JavaScript-2834010-2.patch893 bytesvagelis-prokopiou

Comments

Vagelis created an issue. See original summary.

vagelis-prokopiou’s picture

vagelis-prokopiou commented
Version: 7.x-3.x-dev » 8.x-3.x-dev
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new JavaScript-2834010-2.patch893 bytes
markhalliwell’s picture

markhalliwell
Primary language English
commented
Category: Bug report » Task
Priority: Normal » Minor

Seems rather trivial considering that this is just comments ;)

vagelis-prokopiou’s picture

vagelis-prokopiou commented

What you call "trivial", I call "attention to detail"... Check out the Laravel codebase and you will see what I mean. -:)

  • markcarver committed dbb4e57 on 8.x-3.x authored by Vagelis 
    Issue #2834010 by Vagelis: "Javascript" should be "JavaScript"
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed

We can have attention to detail, but I still think this was rather trivial. Also, this isn't Laravel. Regardless, it's not like this hurts anything. Went ahead and did a regex search and found another spot where it could be changed (see commit).

vagelis-prokopiou’s picture

vagelis-prokopiou commented

Nice! One more error less (if that makes sense) -:)

markhalliwell’s picture

markhalliwell
Primary language English
commented

No it doesn't. The term "error" implies some logically fallacy. There weren't ant typo's in the name (e.g. they had all the correct characters to spell the word). This was just a case issue, which is purely subjective in nature. Trademarks are case insensitive (http://stackoverflow.com/a/3989779/1226717).

vagelis-prokopiou’s picture

vagelis-prokopiou commented

You know something? You are right. I suggest you revert.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.