Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When uninstalling the module, if facetapi is already disabled:
Notice: Use of undefined constant FACETAPI_DATE_YEAR - assumed 'FACETAPI_DATE_YEAR' in search_api_facetapi_uninstall()
Notice: Use of undefined constant FACETAPI_DATE_MONTH - assumed 'FACETAPI_DATE_MONTH' in search_api_facetapi_uninstall()
Notice: Use of undefined constant FACETAPI_DATE_DAY - assumed 'FACETAPI_DATE_DAY' in search_api_facetapi_uninstall()
[...]
The constants are defined in facetapi.module. If facetapi is already disabled then uninstalling will fail to delete the variables.
Maybe use the literal string values? I don't have a better idea atm.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2833482-2--facets_module_uninstall_constants.patch | 1.34 KB | drunken monkey |
| |||
Comments
Comment #2
drunken monkeyThanks a lot for reporting!
You're right, of course, we can't use the constants at this point anymore. The usual troubles of module uninstallation …
Using the literal values instead seems indeed to be the best solution I can think of – only other one would be to manually include the
facetapi.module(if necessary), and I'm pretty sure that's out of the question.Patch attached, please test/review!
Comment #4
drunken monkeyWould have been nice to have a review, but should be fine in any case.
Committed.
Thanks again for reporting!
Comment #5
donquixote CreditAttribution: donquixote as a volunteer commentedOh, sorry.
But yes it looks fine. I don't see what could possibly go wrong.