Entities that don't provide a proper entity URI from a placeholder entity (as used in salesforce_mapping_menu() to determine paths) end up with their SF mapping object pages in strange places. But the listing page doesn't account for these situations, so the operation links are all broken for objects that don't respond properly (like Commerce Orders, or any other object that doesn't pick up its "Salesforce Mapping" tab properly). This causes errors when using these functional links.

Comments

gcb created an issue. See original summary.

gcb’s picture

Status: Active » Needs review
StatusFileSize
new2.21 KB
mariacha1’s picture

StatusFileSize
new4.35 KB

It seems that the real issue is that hook_menu has to rely on different information than SalesforceMappingObject defaultUri() which is leading to re-checking the output values after every call to $salesforce_mapping_object->uri().

The following attached patch uses a helper function to ensure that the same code is called both places, so we don't have to litter our code with if/elses any time we call the uri() method.

Tested with:

Users,
Nodes,
Redhen Contacts,
Recurring Entities.

gcb’s picture

StatusFileSize
new4.46 KB

Last patch has potential to call entity_extract_ids in cases where a mapping is point to a deleted object. This patch fixes that.

aaronbauman’s picture

Status: Needs review » Closed (won't fix)

7.x is no longer supported

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.