acquia_search/config/install/search_api.index.acquia_search_index.yml declares a config dependency on field.storage.node.body, but the module itself does not declare a dependency on the node module.

In a clean install scenario, it is possible for Drupal to attempt to install acquia_search before node, which leads to a unmet dependency error.

Patch attached.

CommentFileSizeAuthor
#2 acquia_search_node_dependency-2833250-2.patch338 bytestimcosgrove

Comments

timcosgrove created an issue. See original summary.

timcosgrove’s picture

timcosgrove commented
StatusFileSize
new acquia_search_node_dependency-2833250-2.patch338 bytes
gg4’s picture

gg4 commented
Status: Active » Needs review
alonaoneill’s picture

alonaoneill commented
Status: Needs review » Needs work

Also according to Drupal standards, modules should include dependencies in the .info.yml file. Also capitalize the name of the module, because module names are proper nouns.
The same issue was open:
https://www.drupal.org/project/acquia_connector/issues/3002073
Looks like, we should close this one?

danepowell’s picture

danepowell commented
Status: Needs work » Needs review

Although #3002073: Capitalize the name of the submodule and dependency namespacing in .info.yml file and this both relate to the info.yml file, I think they should be treated separately.

danepowell’s picture

danepowell commented
Related issues: +#2962395: acquia_search Error on module installation under install profile: unmet dependencies

This seems related to #2962395: acquia_search Error on module installation under install profile: unmet dependencies

  • Dane Powell authored e810357 on 8.x-1.x 
    Fixes #2962395, #2833250, #2726395: Make acquia_search_index config...
danepowell’s picture

danepowell commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.