I found these bugs using this module:
a) After changing the label of a cck field its permission settings are lost.
b) If a label contains quotes no permission settings are saved at all.

Obviously the module uses the label of the cck fields and not their name (which is set only on creation and cannot be changed afterwards) to save the permissions.

This behaviour should be changed.

CommentFileSizeAuthor
#1 283322_1.patch1.95 KBjanusman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

janusman’s picture

janusman CreditAttribution: janusman commented
FileSize
283322_1.patch1.95 KB

Patch for 5.x-1.10. Included an .install file that updates existing permissions strings.

The problem is not only with the CCK field label, but also with the content type label. I needed to do this because i18ncontent.module was sometimes using the translated content type label.

janusman’s picture

janusman CreditAttribution: janusman commented
Status: Active » Needs review

missed setting as needs review.

jayjaydluffy’s picture

jayjaydluffy CreditAttribution: jayjaydluffy commented

I applied the patch, actually just created a file and named it cck_field_perms.install then pasted cck_field_perms_update_11() function as given in the patch. But still no good.

I was actually changing one of my content types and yes, all permissions after changing the Name (just human-readable and not the critical, machine-readable) are gone. Is this patch applicable in this case?

Thanks!

jayjaydluffy’s picture

jayjaydluffy CreditAttribution: jayjaydluffy commented

I think there are some bug in the update query you did in update_11(). It did not rename properly.

Anyway, the patch you did helped a lot to me in understanding the case. For now I just manually changed the things in database coz i don't have enough time to do it.

I'm still subscribing on this.

Thanks!