The scheduler module field-label shows html if the scheduler field is marked as not translatable at /admin/config/regional/content-language

html output

How to reproduce:

  1. Enable Content Translation module
  2. Enable Scheduler module
  3. Edit a content type (e.g. Article)
  4. On 'Language settings' tab -> Enable translation
  5. On 'Scheduler' tab -> Enable Scheduled Publishing
  6. Go to admin -> configuration -> content and language translation
  7. For article, uncheck the scheduler 'publish on' field
  8. In admin -> configuration -> Languages: Add a language
  9. Create an article
  10. In admin -> content, operations -> translate and add a translation
CommentFileSizeAuthor
scheduler_d8_not-translateable.JPG24.97 KBj-lee

Comments

J-Lee created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
Title: Scheduling options field label shows HTML if scheduler is marked as untranslatable » Field label shows HTML if field is marked as not translatable
Project: Scheduler » Content translation
Version: 8.x-1.x-dev »
Component: User Interface » Code
Issue summary: View changes

Hi J-Lee,
I have replicated this, and I don't think it is anything to do with the Scheduler code. The text class 'translation-entity-all-languages' is added in content translation module /content_translation/src/ContentTranslationHandler.php. I think this would be done for any other modules which create node field (but I have not checked this).

I have moved this to the Content Translation issue queue, as that is where it might be fixed.

Jonathan

jonathan1055’s picture

jonathan1055 commented
Project: Content translation » Content translations

Aargh! That 'Content Translation' module project is not the core one. The issue queue does not exist - so moving it again.

jonathan1055’s picture

jonathan1055 commented
Project: Content translations » Core development

This is useless! The project auto-complete gives sandbox projects - no way to find the real Core Translation queue. I am just going to have to put it into Core Development, then it can be moved from there into the appropriate place.

j-lee’s picture

j-lee
he/him
Primary language German
Location 🇩🇪🇪🇺
commented
Project: Core development » Drupal core
Version: » 8.2.3
Component: Code » content_translation.module
Issue summary: View changes

Moving issue to core queue, updating summary.

j-lee’s picture

j-lee
he/him
Primary language German
Location 🇩🇪🇪🇺
commented
Version: 8.2.3 » 8.4.x-dev

Updating Version.

idebr’s picture

idebr commented

This instance should be fixed by the general solution added in #2652850: Title for details form elements is not set as '#markup' and it will be escaped, but all other form elements use '#markup' and are not escaped.

jonathan1055’s picture

jonathan1055 commented
Related issues: +#2652850: Title for details form elements is not set as '#markup' and it will be escaped, but all other form elements use '#markup' and are not escaped

Thanks idebr, I had not seen #2652850: Title for details form elements is not set as '#markup' and it will be escaped, but all other form elements use '#markup' and are not escaped

Yes, I confirm that this does solve the problem. I have just repeated the Steps to Reproduce, seen the error, then applied the patch from #30 of that issue. The html span tags are no longer shown.

I will leave this issue open for a while, but ultimately it can be closed as a duplicate.

Jonathan

j-lee’s picture

j-lee
he/him
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Active » Closed (duplicate)

@idebr and @ jonathan1055 Thank you for the hint and for testing.

I close this in favor for issue #2652850: Title for details form elements is not set as '#markup' and it will be escaped, but all other form elements use '#markup' and are not escaped

jonathan1055’s picture

jonathan1055 commented

OK. Thanks.