Problem/Motivation

When the standard install profile is used and Features is at its default configuration, the

core.entity_view_display.node.article.default

configuration item is assigned to the comment feature rather than the article one.

The problem appears to be that the base assignment plugin currently calls FeaturesManager::assignConfigDependents() after creating packages. In certain cases, this can lead to premature assignment.

core.entity_view_display.node.article.default

has core.entity_view_display.comment.comment.default among its required configuration entities.

Proposed resolution

Remove the call to $this->featuresManager->assignConfigDependents() from FeaturesAssignmentBaseType::assignPackages(). The need seems to be covered by the dependency assignment plugin.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

nedjo created an issue. See original summary.

nedjo’s picture

Status: Active » Needs review
StatusFileSize
new622 bytes

Status: Needs review » Needs work

The last submitted patch, 2: features-assignment-base-2832261-2.patch, failed testing.

nedjo’s picture

Status: Needs work » Needs review
StatusFileSize
new1.32 KB

One of the test failures is from #2833258: Test failure from core change.

Attached patch updates the failing test. We no longer expect the base assignment plugin to handle dependencies.

Status: Needs review » Needs work

The last submitted patch, 4: features-assignment_base-2832261-4.patch, failed testing.

  • nedjo committed a05142c on 8.x-3.x
    Issue #2832261 by nedjo: assignConfigDependents() runs too early in...
nedjo’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.