Hello,

As discussed in #2830562-7: Update translations on managed sites, it would be easier to provide condition on module if the _hosting_sync_site_has_module() function could be in the hosting project.

I will provide two patches for that.

CommentFileSizeAuthor
#3 hosting-refactor_hosting_sync_site_has_module-2832110-3.patch1009 bytesgrimreaper
#3 hosting_tasks_extra-refactor_hosting_sync_site_has_module-2388214-3.patch2.23 KBgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Title: Refactoring of » Refactoring of _hosting_sync_site_has_module
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review
StatusFileSize
new hosting_tasks_extra-refactor_hosting_sync_site_has_module-2388214-3.patch2.23 KB
new hosting-refactor_hosting_sync_site_has_module-2832110-3.patch1009 bytes

Here are the patches.

I also add a validation on the features revert all task to check if the features module is enabled.

And so I can see that the code that check if a module is enabled as a problem on a D8 site I used as test. I will see if there is already an issue for that and otherwise I will open another one.

Thanks for the review.

helmo’s picture

helmo commented
Status: Needs review » Fixed

Thanx, both have been committed.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Thanks for the commits :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.