After release of Workbench Moderation 3.0, the workflow for saving revisions was heavily changed. Before it was like described in this module:
The steps taken by Workbench Moderation is to save the forward revision first and overwrite this with the live version in a shutdown function in a second step.
The way metatag module detected if it was a live revision was through function "_metatag_isdefaultrevision($entity)" which was checking if field $entity->workbench_moderation['updating_live_revision'] was defined.
Now in Workbench Moderation 3.0 we don't have the live revision concept and neither this "updating_live_revision" field anywhere.
If I understood correctly, every time we save a node two new revisions are created, one is a copy of the old version and the other is the new version. They should have the metatag processed.
My patch simply removes the logic to detect if it is a live revision.
The reason why I consider this issue as Minor, is because the behavior is the same before and after the patch ($entity->workbench_moderation['updating_live_revision'] is now always empty and so _metatag_isdefaultrevision($entity) returns always FALSE)...
Comment | File | Size | Author |
---|---|---|---|
#13 | metatag-n2831073-13.patch | 8.64 KB | DamienMcKenna |
| |||
#13 | metatag-n2831073-13.interdiff.txt | 1.69 KB | DamienMcKenna |
#12 | metatag-n2831073-11.patch | 6.95 KB | dxvargas |
| |||
#10 | metatag-n2831073-10.patch | 7.23 KB | dxvargas |
#9 | metatag-n2831073-9.patch | 4.16 KB | DamienMcKenna |
|
Comments
Comment #2
dxvargas CreditAttribution: dxvargas commentedComment #3
DamienMcKennaThanks for reporting this and taking the time to put a patch together. Lets see what the testbot says about the patch.
Comment #4
DamienMcKennaAt this point, lets add some tests to confirm it all works correctly.
Comment #5
DamienMcKennaThis adds WM as a test dependency.
Comment #6
DamienMcKennaComment #8
DamienMcKennaOk, that minor piece was committed, now back to needing work to add the tests.
Comment #9
DamienMcKennaThis adds a placeholder file to put the tests in.
Comment #10
dxvargas CreditAttribution: dxvargas commentedI have added a test in the placeholder given in #9.
Comment #12
dxvargas CreditAttribution: dxvargas commentedSorry, wrong path for files... submitting again!
Comment #13
DamienMcKennaThis adds a hook_requirements() error if an old version of WM is installed.
Comment #14
DamienMcKennaCommitted. Thanks!
Comment #16
drummBumping issue for #2839776: Parent issues no longer diplay?
Comment #17
hass CreditAttribution: hass commentedThanks for breaking wb 1.x support. As you may know wb 3.x is so buggy that people should not use it. Never release a security release for metatag.
I hope we can simply downgrade metatag module without loosing data.
@todo: Add a requirement hook to metatag so the upgrade stops and does not complete before wb 3.x is installed.
Comment #18
DamienMcKennaPlease see #2840500: Incompatibility with workbench_moderation 7.x-1.x where this was rolled back with some changes to make them optional based upon which version of Workbench Moderation is installed.