A previos patch introduces notices when no group exists:

Notice: Undefined offset: 0 en include() (line 15 sites/all/modules/contrib/views_datasource/views/theme/views-views-json-style-simple.tpl.php).
Notice: Undefined index: en include() (line 18 de sites/all/modules/contrib/views_datasource/views/theme/views-views-json-style-simple.tpl.php).
Notice: Trying to get property of non-object en include() (línea 18 de sites/all/modules/contrib/views_datasource/views/theme/views-views-json-style-simple.tpl.php).
CommentFileSizeAuthor
#2 views_datasource-remove_notices_on_group-2830934-2.patch1.69 KBgedur

Comments

GeduR created an issue. See original summary.

gedur’s picture

gedur commented
Status: Active » Needs work
StatusFileSize
new views_datasource-remove_notices_on_group-2830934-2.patch1.69 KB

Please review

gedur’s picture

gedur commented
Issue summary: View changes
gedur’s picture

gedur commented
Status: Needs work » Needs review
jacob.embree’s picture

jacob.embree commented
Status: Needs review » Reviewed & tested by the community

Nice patch.

marceldeb’s picture

marceldeb commented

Very nice patch indeed!

hgoto’s picture

hgoto commented

Thank for the patch. The patch #2 works well. +1 for RTBC.

hgoto’s picture

hgoto commented
Related issues: +#1373280: Grouping for nodes 7.x

"previos patch" in the summary points the following patch.

#1373280-5: Grouping for nodes 7.x

nithinkolekar’s picture

nithinkolekar commented

RTBC
patch tested manually..

rjbrown99’s picture

rjbrown99 commented

#2 applied fine for me and worked to resolve the problem. It's already RTBC but wanted to chime in with one more positive result.

  • ZeiP committed b579843 on 7.x-1.x authored by GeduR 
    Issue #2830934 by GeduR: Remove notices on group style simple
zeip’s picture

zeip commented
Status: Reviewed & tested by the community » Fixed

Looks good, thanks everyone! Committed the patch to 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.