I always get a warning when i delete backups. I took a look inside the code and found out that
in the function backup_db_history_delete is a typo.
current code

/**
 * Delete history entry.
 */
function backup_db_history_delete($id) {
  // Remove backup_db entry.
  // @todo, use injected db service.
  db_delete('backup_db')
    ->condition('fid', $id)
    ->execute();

  // Remove file and managed entry.
  return file_delete($fid);
}

should be

/**
 * Delete history entry.
 */
function backup_db_history_delete($id) {
  // Remove backup_db entry.
  // @todo, use injected db service.
  db_delete('backup_db')
    ->condition('fid', $id)
    ->execute();

  // Remove file and managed entry.
  return file_delete($id);
}

I created a patch to fix this

CommentFileSizeAuthor
#2 2830711-typo-in-delete-backup-history.patch389 bytesAnonymous (not verified)
typo-in-deletebackup-history.patch389 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Almare created an issue. See original summary.

Anonymous’s picture

StatusFileSize
new389 bytes

  • swim committed fe5eff3 on 8.x-1.x authored by Almare
    Issue #2830711 by Almare: Typo in backup_db_history_delete
    
swim’s picture

Version: 8.x-1.0 » 8.x-1.x-dev
Status: Active » Fixed

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.