The current implementation to set a text area as readonly uses the disabled attribute but in IE scrollbars do not work with that attribute and we have a long terms of service we want people to agree to.
I think the attribute <textarea readonly=""> would be better to use because that works in IE with scrollbars.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | webform_readonly.patch | 11.07 KB | quicksketch |
| #2 | 283041_readonly_textarea.patch | 1.02 KB | deviantintegral |
Comments
Comment #1
quicksketchWebform has a generally larger issue that the form shouldn't be used for viewing results at all, but this could be a quick modest improvement over using disabled elements.
Comment #2
deviantintegral commentedHere's a patch fixing this against the Drupal 5 version, but it also applies cleanly to the Drupal 6 version. Hopefully this can be committed to the next release.
Enjoy!
--Andrew
Comment #3
deviantintegral commentedComment #4
quicksketchI've delayed putting in this patch since it doesn't account for other fields (email, textfield, hiddens) that would benefit from this change as well. Here's a patch that affects all components and tidies up the code styling a bit for the display functions.
Comment #5
quicksketchI went ahead and committed the changes. Please reopen if these caused other issues or don't work as expected.
Comment #6
deviantintegral commentedI didn't test this, but did read over the code and it looks good. Thanks!
--Andrew