Problem/Motivation

File translator has support for import/export of HTML translations.

\Drupal\tmgmt_file\Plugin\tmgmt_file\Format\Html::import() has an $is_file parameter which tells if the first parameter is the file name or the actual translation.
The logic to support it is missing.

Proposed resolution

Support direct HTML content import using $is_file flag.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 html_file_format-2830011-2.patch649 bytesmbovan

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan commented
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new html_file_format-2830011-2.patch649 bytes

Quick patch fix. Still needs test coverage.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: HTML file format doesn't respect $is_file flag » Add tests for $is_file flag (was: HTML file format doesn't respect $is_file flag)
Status: Needs review » Active
Issue tags: -Needs tests

Looks like we don't have test coverage for the $is_file flag for XLIFF either?

We don't actually rely on this anymore, so I committed the fix and keeping this open to add test coverage.

  • Berdir committed a7ec825 on 8.x-1.x authored by mbovan 
    Issue #2830011 by mbovan: HTML file format doesn't respect $is_file flag