Problem/Motivation

In #2029677: Convert BLOCK_LABEL_VISIBLE to a constant on the block interface BLOCK_LABEL_VISIBLE was converted from a constant in block.module to a constant on BlockInterface.
Back then, both BlockPluginInterface and BlockInterface lived in block.module, and since no one noticed that all non-test usages were in a class implementing BlockPluginInterface and not BlockInterface, it was added to the wrong file.

Proposed resolution

Fix this! Leave the old one deprecated. Update the handful of usages.

Remaining tasks

N/A

User interface changes

N/A

API changes

"New" constant on BlockPluginInterface

Data model changes

N/A

CommentFileSizeAuthor
#2 2829680-constant-2.patch6.35 KBtim.plunkett

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

Status: Active » Needs review
StatusFileSize
new6.35 KB
andypost’s picture

Status: Needs review » Reviewed & tested by the community

Great to this fixed.
I checked usage and all places covered with the patch.
Also this really belongs to plugin not the entity

andypost’s picture

xjm’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

Looks great! We need a tiny CR for the deprecation.

tim.plunkett’s picture

Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs change record

Resetting to RTBC since that was a pretty straightforward CR
https://www.drupal.org/node/2829775

  • xjm committed 0e75873 on 8.3.x
    Issue #2829680 by tim.plunkett, andypost: BLOCK_LABEL_VISIBLE is defined...
xjm’s picture

Status: Reviewed & tested by the community » Fixed

Committed 0e75873 and pushed to 8.3.x. Thanks! Feels good to clean this up.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.