I have created a simple refactoring patch for drush dcer which removes some code duplication.

CommentFileSizeAuthor
#5 default_content-drush_dcer_refactoring-2827140-5-d8.patch1.08 KBao2
#2 default_content-drush_dcer_refactoring-2827140-2-d8.patch1.15 KBSyndz

Comments

Syndz created an issue. See original summary.

Syndz’s picture

Syndz commented
Status: Active » Needs review
StatusFileSize
new default_content-drush_dcer_refactoring-2827140-2-d8.patch1.15 KB

Added the patch.

Status: Needs review » Needs work

The last submitted patch, 2: default_content-drush_dcer_refactoring-2827140-2-d8.patch, failed testing.

Syndz’s picture

Syndz commented
Assigned: Syndz » Unassigned
Status: Needs work » Needs review

I'm not sure why this patch fails testing, it applies cleanly for me.

ao2’s picture

ao2 commented
StatusFileSize
new default_content-drush_dcer_refactoring-2827140-5-d8.patch1.08 KB

The original patch used a prefix level of 0 in the file paths (i.e. you need patch -p0 to apply it), while git patches usually use -p1, maybe the test bot assumes the latter?

I am attaching a refreshed patch which also updates the hunk context to apply cleanly with git apply on the latest code.

The interdiff with the previous patch is null.

Ciao,
Antonio

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Great clean-up, thanx

  • andypost committed f0d9025 on 8.x-1.x authored by ao2 
    Issue #2827140 by Syndz, ao2: Simple refactoring of drush dcer
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

Thanx! commited & pushed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.